handle another type of collapsible if-statement #15104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
This PR is an updated version of PR #15027. |
samueltardieu
requested changes
Jun 23, 2025
rustbot
added
S-waiting-on-author
… previous commit. Correct specifying of applicability for calls to functions that modify an `Applicability`. Update suggestion message to adhere to standard conventions. Change default value passed to `Sugg::hir_with_applicability` to a suitable one. Format code. Update the corresponding `stderr` file for this lint.
rustbot
added
S-waiting-on-review
|
@samueltardieu Thanks for the review, I have implemented your suggested changes in my latest commit and was wondering if you could re-review it? |
samueltardieu
requested changes
Jul 1, 2025
Comment on lines
+236
to
+240
| let new_bin_op = if let BinOpKind::Ne = bin_op.node { | ||
| BinOpKind::Eq | ||
| } else { | ||
| BinOpKind::Ne | ||
| }; |
There was a problem hiding this comment.
What about other binary operations? Right now, the following
let a = 10;
let b = 20;
if a < 20 {
if b < 30 {
println!("Hello");
}
} else {
println!("world!");
}will be transformed into the (non equivalent)
if a != 20 || b < 30 {
println!("Hello world!");
}You should look at the ! operator for Sugg and let it invert the operation, it might be beneficial.
rustbot
added
S-waiting-on-author
Thanks for the review, I'll work on implementing those suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #812
changelog: [
collapsible_if]: handle another type of collapsible if-statement