Skip to content

Don't remove explicit cast to trait object pointer #15145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't remove explicit cast to trait object pointer #15145

wants to merge 1 commit into from

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented Jun 26, 2025 •
edited by llogiq
Loading

Fixes #15141

changelog: [borrow_as_ptr]: do not remove cast to trait object pointer

@rustbot
Copy link
Collaborator

rustbot commented Jun 26, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 26, 2025
llogiq
llogiq approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@llogiq llogiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from a very small nit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llogiq llogiq llogiq approved these changes

Assignees

@llogiq llogiq

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

borrow-as-ptr causes type change
3 participants
@samueltardieu @rustbot @llogiq