Skip to content

Come up with better names for run_make_support symbol helpers #143933

Open
@jieyouxu

Description

@jieyouxu

When I was reading through the test cases, these function names seemed to blur into one another. object_contains_any_symbol_substring, object_contains_all_symbol_substring, object_contains_any_symbol and object_contains_all_symbols are all long names sometimes with only a few characters difference in the middle. So I could see mistakes being missed.

However, I don't have a clear idea of what would be an improvement here (hence why I don't want to block this). Maybe some more namespacing or an iterator type? Idk.

Originally posted by @ChrisDenton in #143837 (review)

I.e. less symbol (hah) soup names for

Substring match Exact match
Match any object_contains_any_symbol_substring object_contains_any_symbol
Match all object_contains_all_symbol_substring object_contains_all_symbols

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-run-makeArea: port run-make Makefiles to rmake.rsC-enhancementCategory: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions