add LinkedList::{retain,retain_mut}

[TennyZhuang]

Implement #114135

The API is consistent with other collections.

[rustbot]

r? @thomcc

(rustbot has picked a reviewer for you, use r? to override)

[thomcc]

Can you file an ACP for this? https://github.com/rust-lang/libs-team/issues/new?assignees=&labels=api-change-proposal%2C+T-libs-api&template=api-change-proposal.md&title=%28My+API+Change+Proposal%29

[TennyZhuang]

Can you file an ACP for this? https://github.com/rust-lang/libs-team/issues/new?assignees=&labels=api-change-proposal%2C+T-libs-api&template=api-change-proposal.md&title=%28My+API+Change+Proposal%29

Thanks! I'll add it tomorrow

[TennyZhuang]

rust-lang/libs-team#250

[thomcc]

This has ACP+, and the implementation looks fine.

@bors r+

[bors]

📌 Commit 5df60f4 has been approved by thomcc

It is now in the queue for this repository.

[bors]

⌛ Testing commit 5df60f4 with merge f665b31...

[rust-log-analyzer]

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] rustc_hir_analysis test:false 132.715
[RUSTC-TIMING] rustc_mir_build test:false 131.260
[RUSTC-TIMING] rustc_lint test:false 87.084
[RUSTC-TIMING] rustc_ty_utils test:false 43.730
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
##[group]Clock drift check
##[group]Clock drift check
Session terminated, killing shell... ...killed.
  network time: 
##[error]The operation was canceled.
Cleaning up orphan processes

[bors]

💔 Test failed - checks-actions

[thomcc]

@rustbot author

[bors]

⌛ Testing commit 5df60f4 with merge 1a3aa4a...

[bors]

☀️ Test successful - checks-actions
Approved by: thomcc
Pushing 1a3aa4a to master...

[rust-timer]

Finished benchmarking commit (1a3aa4a): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.6%	[0.6%, 2.7%]	2
Regressions ❌ (secondary)	2.7%	[2.5%, 2.9%]	2
Improvements ✅ (primary)	-2.1%	[-2.6%, -1.5%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.2%	[-2.6%, 2.7%]	4

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.092s -> 668.465s (-0.09%)
Artifact size: 314.12 MiB -> 314.06 MiB (-0.02%)

[jdahlstrom]

Wasn't this supposed to only have the single retain method, as per the ACP?