Skip to content

std::net: adding unix_socket_exclbind feature for solaris/illumos. #123476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2025
Merged

std::net: adding unix_socket_exclbind feature for solaris/illumos. #123476

merged 1 commit into from
Jun 29, 2025
+117 −0

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Apr 4, 2024 •
edited by Dylan-DPC
Loading

allows to have a tigher control over the binding exclusivness of the socket.

ACP: rust-lang/libs-team#366

@rustbot
Copy link
Collaborator

rustbot commented Apr 4, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-solaris Operating system: Solaris O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 4, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@devnexen devnexen force-pushed the std_net_solaris_exclbind branch 2 times, most recently from 72f141f to ec6cc6c Compare April 4, 2024 22:24
@devnexen devnexen marked this pull request as ready for review April 4, 2024 22:50
@Mark-Simulacrum
Copy link
Member

Can you file an ACP for this change?

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2024
@devnexen devnexen mentioned this pull request Apr 5, 2024
Closed
@devnexen
Copy link
Contributor Author

devnexen commented Apr 5, 2024

Sure thing.

@devnexen
Copy link
Contributor Author

devnexen commented Apr 5, 2024

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 5, 2024
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2024
@devnexen
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 15, 2024
@Mark-Simulacrum Mark-Simulacrum removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 20, 2024
@Mark-Simulacrum
Copy link
Member

Please mark as ready only once/if the ACP has been accepted.

@bors
Copy link
Collaborator

bors commented Feb 6, 2025

☔ The latest upstream changes (presumably #136572) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 6, 2025
@LFS6502 LFS6502 added S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. and removed S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. labels Mar 1, 2025
@devnexen
std::net: adding unix_socket_exclbind feature for solaris/illumos.
1bbabb7 
allows to have a tigher control over the binding exclusivness of the
socket.
@devnexen devnexen force-pushed the std_net_solaris_exclbind branch from ec6cc6c to 1bbabb7 Compare June 10, 2025 18:47
@Dylan-DPC Dylan-DPC added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 15, 2025
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 28, 2025

📌 Commit 1bbabb7 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 28, 2025
@matthiaskrgr
Rollup merge of rust-lang#123476 - devnexen:std_net_solaris_exclbind,…
fa175c1 
… r=Mark-Simulacrum

std::net: adding `unix_socket_exclbind` feature for solaris/illumos.

allows to have a tigher control over the binding exclusivness of the socket.

ACP: rust-lang/libs-team#366
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 28, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 28, 2025
@matthiaskrgr
Rollup merge of rust-lang#123476 - devnexen:std_net_solaris_exclbind,…
a7964a5 
… r=Mark-Simulacrum

std::net: adding `unix_socket_exclbind` feature for solaris/illumos.

allows to have a tigher control over the binding exclusivness of the socket.

ACP: rust-lang/libs-team#366
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 28, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 28, 2025
@matthiaskrgr
Rollup merge of rust-lang#123476 - devnexen:std_net_solaris_exclbind,…
fa266fe 
… r=Mark-Simulacrum

std::net: adding `unix_socket_exclbind` feature for solaris/illumos.

allows to have a tigher control over the binding exclusivness of the socket.

ACP: rust-lang/libs-team#366
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 28, 2025
Closed
bors added a commit that referenced this pull request Jun 28, 2025
@bors
Auto merge of #143148 - matthiaskrgr:rollup-xlijz8h, r=matthiaskrgr
fa50220 
Rollup of 10 pull requests

Successful merges:

 - #123476 (std::net: adding `unix_socket_exclbind` feature for solaris/illumos.)
 - #142708 (Do not include NUL-terminator in computed length)
 - #142963 (Skip unnecessary components in x64 try builds)
 - #142987 (rustdoc: show attributes on enum variants)
 - #143031 (Add windows-gnullvm hosts to the manifest)
 - #143082 (update internal `send_signal` comment)
 - #143110 (Use tidy to sort `sym::*` items)
 - #143111 (BTreeSet: remove duplicated code by reusing `from_sorted_iter`)
 - #143114 (Minor Documentation Improvements)
 - #143137 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 28, 2025
@matthiaskrgr
Rollup merge of rust-lang#123476 - devnexen:std_net_solaris_exclbind,…
d080a64 
… r=Mark-Simulacrum

std::net: adding `unix_socket_exclbind` feature for solaris/illumos.

allows to have a tigher control over the binding exclusivness of the socket.

ACP: rust-lang/libs-team#366
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 28, 2025
Closed
bors added a commit that referenced this pull request Jun 28, 2025
@bors
Auto merge of #143153 - matthiaskrgr:rollup-9o7vdtp, r=matthiaskrgr
6745297 
Rollup of 10 pull requests

Successful merges:

 - #123476 (std::net: adding `unix_socket_exclbind` feature for solaris/illumos.)
 - #142708 (Do not include NUL-terminator in computed length)
 - #142963 (Skip unnecessary components in x64 try builds)
 - #142974 (Update stage0 to 1.89.0-beta.1)
 - #142987 (rustdoc: show attributes on enum variants)
 - #143031 (Add windows-gnullvm hosts to the manifest)
 - #143082 (update internal `send_signal` comment)
 - #143110 (Use tidy to sort `sym::*` items)
 - #143111 (BTreeSet: remove duplicated code by reusing `from_sorted_iter`)
 - #143114 (Minor Documentation Improvements)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 28, 2025
Merged
bors added a commit that referenced this pull request Jun 28, 2025
@bors
Auto merge of #143157 - matthiaskrgr:rollup-90rtm3a, r=<try>
32c9875 
Rollup of 9 pull requests

Successful merges:

 - #123476 (std::net: adding `unix_socket_exclbind` feature for solaris/illumos.)
 - #142708 (Do not include NUL-terminator in computed length)
 - #142963 (Skip unnecessary components in x64 try builds)
 - #142987 (rustdoc: show attributes on enum variants)
 - #143031 (Add windows-gnullvm hosts to the manifest)
 - #143082 (update internal `send_signal` comment)
 - #143110 (Use tidy to sort `sym::*` items)
 - #143111 (BTreeSet: remove duplicated code by reusing `from_sorted_iter`)
 - #143114 (Minor Documentation Improvements)

r? `@ghost`
`@rustbot` modify labels: rollup

try-job: dist-i586-gnu-i586-i686-musl
bors added a commit that referenced this pull request Jun 28, 2025
@bors
Auto merge of #143157 - matthiaskrgr:rollup-90rtm3a, r=matthiaskrgr
cf38b8e 
Rollup of 9 pull requests

Successful merges:

 - #123476 (std::net: adding `unix_socket_exclbind` feature for solaris/illumos.)
 - #142708 (Do not include NUL-terminator in computed length)
 - #142963 (Skip unnecessary components in x64 try builds)
 - #142987 (rustdoc: show attributes on enum variants)
 - #143031 (Add windows-gnullvm hosts to the manifest)
 - #143082 (update internal `send_signal` comment)
 - #143110 (Use tidy to sort `sym::*` items)
 - #143111 (BTreeSet: remove duplicated code by reusing `from_sorted_iter`)
 - #143114 (Minor Documentation Improvements)

r? `@ghost`
`@rustbot` modify labels: rollup

try-job: dist-i586-gnu-i586-i686-musl
@bors bors merged commit 7394bd5 into rust-lang:master Jun 29, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jun 29, 2025
rust-timer added a commit that referenced this pull request Jun 29, 2025
@rust-timer
Unrolled build for #123476
032878f 
Rollup merge of #123476 - devnexen:std_net_solaris_exclbind, r=Mark-Simulacrum

std::net: adding `unix_socket_exclbind` feature for solaris/illumos.

allows to have a tigher control over the binding exclusivness of the socket.

ACP: rust-lang/libs-team#366
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jun 29, 2025
@bors
Auto merge of #143157 - matthiaskrgr:rollup-90rtm3a, r=matthiaskrgr
6b0d277 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#123476 (std::net: adding `unix_socket_exclbind` feature for solaris/illumos.)
 - rust-lang/rust#142708 (Do not include NUL-terminator in computed length)
 - rust-lang/rust#142963 (Skip unnecessary components in x64 try builds)
 - rust-lang/rust#142987 (rustdoc: show attributes on enum variants)
 - rust-lang/rust#143031 (Add windows-gnullvm hosts to the manifest)
 - rust-lang/rust#143082 (update internal `send_signal` comment)
 - rust-lang/rust#143110 (Use tidy to sort `sym::*` items)
 - rust-lang/rust#143111 (BTreeSet: remove duplicated code by reusing `from_sorted_iter`)
 - rust-lang/rust#143114 (Minor Documentation Improvements)

r? `@ghost`
`@rustbot` modify labels: rollup

try-job: dist-i586-gnu-i586-i686-musl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
O-solaris Operating system: Solaris O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
7 participants
@devnexen @rustbot @rust-log-analyzer @Mark-Simulacrum @bors @LFS6502 @Dylan-DPC