Skip to content

core: Document FormatWriter and allow write! #14258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2014

Conversation

alexcrichton
Copy link
Member

This commit fills in the documentation holes for the FormatWriter trait which
were previously accidentally left blank. Additionally, this adds the write_fmt
method to the trait to allow usage of the write! macro with implementors of
the FormatWriter trait. This is not useful for consumers of the standard
library who should generally avoid the FormatWriter trait, but it is useful
for consumers of the core library who are not using the standard library.

@emberian
Copy link
Member

Travis failure is legit

This commit fills in the documentation holes for the FormatWriter trait which
were previously accidentally left blank. Additionally, this adds the `write_fmt`
method to the trait to allow usage of the `write!` macro with implementors of
the `FormatWriter` trait. This is not useful for consumers of the standard
library who should generally avoid the `FormatWriter` trait, but it is useful
for consumers of the core library who are not using the standard library.
@alexcrichton
Copy link
Member Author

Oops, I think it should be taken care of now.

bors added a commit that referenced this pull request May 18, 2014
This commit fills in the documentation holes for the FormatWriter trait which
were previously accidentally left blank. Additionally, this adds the `write_fmt`
method to the trait to allow usage of the `write!` macro with implementors of
the `FormatWriter` trait. This is not useful for consumers of the standard
library who should generally avoid the `FormatWriter` trait, but it is useful
for consumers of the core library who are not using the standard library.
@bors bors closed this May 18, 2014
@bors bors merged commit 14d3dbe into rust-lang:master May 18, 2014
@alexcrichton alexcrichton deleted the dox-format-writer branch May 19, 2014 15:57
bors pushed a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2025
…-lang#14258)

`assert_eq!()` and `assert_ne!()` are not expanded the same way as
`assert!()` (they use a `match` instead of a `if`). This makes them
being recognized as well.

Fix rust-lang/rust-clippy#14255

changelog: [`missing_asserts_for_indexing`]: consider `assert_eq!()` as
well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants