Lazy-ify some markdown rendering #142910
Open
Lazy-ify some markdown rendering #142910
+103
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
GuillaumeGomez
approved these changes
Jun 23, 2025
|
Code changes look good to me. Curious to see the impact on performance. =D @bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
bors
added a commit
that referenced
this pull request
Jun 23, 2025
… r=<try> Lazy-ify some markdown rendering Seems to have a positive effect in my local perf runs 😍 r? `@GuillaumeGomez` if you're interested, otherwise feel free to reassign (would also love a perf run)
This comment has been minimized.
This comment has been minimized.
yotamofek
force-pushed
the
pr/rustdoc/markdown-lazy-to-string
branch
from
d6cfa0b to
107b018
Compare
|
@GuillaumeGomez I had a unit test that failed to compile. Would love to re-trigger the perf run (maybe we can just perf the commit that failed the CI but passed the try build?) |
|
@rust-timer build c4d5641 |
|
Queued c4d5641 with parent ae2fc97, future comparison URL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to have a positive effect in my local perf runs 😍
r? @GuillaumeGomez if you're interested, otherwise feel free to reassign
(would also love a perf run)