Rewrite .gitattributes CRLF ui tests into run-make tests
#142925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-run-make
|
|
Oneirical
force-pushed
the
unattentive-immobility
branch
2 times, most recently
from
4b34c01 to
1475a51
Compare
This comment has been minimized.
This comment has been minimized.
Oneirical
force-pushed
the
unattentive-immobility
branch
from
1475a51 to
580b27c
Compare
|
This PR modifies cc @jieyouxu |
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
Oneirical
force-pushed
the
unattentive-immobility
branch
from
580b27c to
12e1f3d
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
jieyouxu
approved these changes
Jun 26, 2025
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Jun 26, 2025
…r=jieyouxu Rewrite `.gitattributes` CRLF ui tests into run-make tests These tests are difficult to edit. Even adding a newline to the original UI test breaks it, as all newlines in them are supposed to be `\r\n`. (Except for `trailing-carriage-return-in-string`, which only has SOME CRLF) In the run-make suite, the test is instead automatically generated with `\r\n` clearly visible, making fixes easier. Closes rust-lang#140033 Closes rust-lang#139968 r? `@jieyouxu`
bors
added a commit
that referenced
this pull request
Jun 26, 2025
Rollup of 17 pull requests Successful merges: - #124595 (Suggest cloning `Arc` moved into closure) - #139594 (Simplify `ObligationCauseCode::IfExpression`) - #141311 (make `tidy-alphabetical` use a natural sort) - #141648 ([rustdoc] Do not emit redundant_explicit_links lint if the doc comment comes from expansion) - #142255 (Add edition checks for some tests that had divergent output) - #142285 (tests: Do not run afoul of asm.validity.non-exhaustive in input-stats) - #142549 (small iter.intersperse.fold() optimization) - #142637 (Remove some glob imports from the type system) - #142647 ([perf] Compute hard errors without diagnostics in impl_intersection_has_impossible_obligation) - #142700 (Remove incorrect comments in `Weak`) - #142884 (StableMIR: Add method to retrieve body of coroutine) - #142925 (Rewrite `.gitattributes` CRLF ui tests into run-make tests) - #143001 (Rename run always ) - #143010 (Update `browser-ui-test` version to `0.20.7`) - #143015 (Add `sym::macro_pin` diagnostic item for `core::pin::pin!()`) - #143020 (codegen_fn_attrs: make comment more precise) - #143033 (Expand const-stabilized API links in relnotes) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are difficult to edit. Even adding a newline to the original UI test breaks it, as all newlines in them are supposed to be
\r\n. (Except fortrailing-carriage-return-in-string, which only has SOME CRLF)In the run-make suite, the test is instead automatically generated with
\r\nclearly visible, making fixes easier.Closes #140033
Closes #139968
r? @jieyouxu