fresh binding should shallow the def after expand #143141
Open
+84
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
bvanjoi
commented
Jun 28, 2025
| @@ -217,6 +217,8 @@ pub(crate) enum RibKind<'ra> { | |||
| /// We passed through a `macro_rules!` statement | |||
| MacroDefinition(DefId), | |||
|
|
|||
| LookAheadMacroDefinition(DefId), | |||
There was a problem hiding this comment.
The reason for using RibKind::LookAheadMacroDefinition instead of RibKind::MacroDefinition is to prevent cases like:
fn f() {
let x = 0;
macro_rules! foo { () => {
assert_eq!(x, 0); // it will make `x` equal `1` if we use `RibKind::MacroDefinition`
} }
let x = 1;
foo!();
}
bvanjoi
commented
Jun 28, 2025
| fn f3() { | ||
| let f = || -> i16 { 42 }; | ||
|
|
||
| let a: i16 = m!(); |
There was a problem hiding this comment.
This case would previously fail to compile.
bvanjoi
commented
Jun 28, 2025
| fn f() -> i8 { 42 } | ||
| let f = || -> i16 { 42 }; | ||
|
|
||
| let a: i16 = m!(); |
There was a problem hiding this comment.
This is breaking changes, should we run crate tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95237
r? @petrochenkov or @cjgillot