Port `#[no_implicit_prelude]` to the new attribute parsing infrastructure #143237

JonathanBrouwer · 2025-06-30T14:07:43Z

Ports no_implicit_prelude to the new attribute parsing infrastructure for #131229 (comment)

r? @oli-obk
cc @jdonszelmann

rustbot · 2025-06-30T14:09:24Z

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

oli-obk · 2025-07-01T15:28:55Z

@bors r+ rollup

bors · 2025-07-01T15:28:58Z

📌 Commit a96330e has been approved by oli-obk

It is now in the queue for this repository.

Rollup of 12 pull requests Successful merges: - #136801 (Implement `Random` for tuple) - #141867 (Describe Future invariants more precisely) - #142760 (docs(fs): Touch up grammar on lock api) - #143181 (Improve testing and error messages for malformed attributes) - #143210 (`tests/ui`: A New Order [19/N] ) - #143212 (`tests/ui`: A New Order [20/N]) - #143230 ([COMPILETEST-UNTANGLE 2/N] Make some compiletest errors/warnings/help more visually obvious) - #143240 (Port `#[rustc_object_lifetime_default]` to the new attribute parsing …) - #143255 (Do not enable LLD by default in the dist profile) - #143262 (mir: Mark `Statement` and `BasicBlockData` as `#[non_exhaustive]`) - #143269 (bootstrap: make comment more clear) - #143279 (Remove `ItemKind::descr` method) Failed merges: - #143237 (Port `#[no_implicit_prelude]` to the new attribute parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

JonathanBrouwer · 2025-07-01T22:15:43Z

^ Rebased because of conflicts
@oli-obk

oli-obk · 2025-07-02T13:46:25Z

@bors r+ rollup

bors · 2025-07-02T13:46:28Z

📌 Commit f793856 has been approved by oli-obk

It is now in the queue for this repository.

GrigorenkoPV · 2025-07-02T14:02:26Z

Another candidate for #142964, nice

JonathanBrouwer · 2025-07-03T05:51:07Z

^ Rebased on #142964, now using the NoArgsAttributeParser :D
@rustbot ready
@oli-obk

oli-obk · 2025-07-03T08:03:35Z

@bors r+ rollup

bors · 2025-07-03T08:03:39Z

📌 Commit e27211a has been approved by oli-obk

It is now in the queue for this repository.

jdonszelmann · 2025-07-03T11:32:55Z

@bors rollup=never

jdonszelmann · 2025-07-03T11:33:40Z

seems surprisingly conflicty 🤷

Rollup of 6 pull requests Successful merges: - #134006 (setup typos check in CI) - #142876 (Port `#[target_feature]` to new attribute parsing infrastructure) - #143038 (avoid suggesting traits from private dependencies) - #143083 (Fix rustdoc not correctly showing attributes on re-exports) - #143283 (document optional jobs) - #143329 (minicore: use core's `diagnostic::on_unimplemented` messages) Failed merges: - #143237 (Port `#[no_implicit_prelude]` to the new attribute parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-07-03T17:58:08Z

☔ The latest upstream changes (presumably #143363) made this pull request unmergeable. Please resolve the merge conflicts.

…ture Signed-off-by: Jonathan Brouwer <[email protected]>

JonathanBrouwer · 2025-07-03T19:01:47Z

^ Rebased (again :P) on master
@rustbot ready
@jdonszelmann @oli-obk whoever comes first
Imo this can be rolled up, should be fine

jdonszelmann · 2025-07-03T19:09:29Z

@bors r+

bors · 2025-07-03T19:09:32Z

📌 Commit fee5e3c has been approved by jdonszelmann

It is now in the queue for this repository.

jdonszelmann · 2025-07-03T19:09:59Z

@bors r=jdonszelmann,oli-obk

bors · 2025-07-03T19:10:01Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Weekly cargo update #142857

bors · 2025-07-03T19:10:02Z

📌 Commit fee5e3c has been approved by jdonszelmann,oli-obk

It is now in the queue for this repository.

jdonszelmann · 2025-07-03T19:11:00Z

No attr prs in the queue, back to @bors rollup=iffy

Rollup of 6 pull requests Successful merges: - rust-lang/rust#134006 (setup typos check in CI) - rust-lang/rust#142876 (Port `#[target_feature]` to new attribute parsing infrastructure) - rust-lang/rust#143038 (avoid suggesting traits from private dependencies) - rust-lang/rust#143083 (Fix rustdoc not correctly showing attributes on re-exports) - rust-lang/rust#143283 (document optional jobs) - rust-lang/rust#143329 (minicore: use core's `diagnostic::on_unimplemented` messages) Failed merges: - rust-lang/rust#143237 (Port `#[no_implicit_prelude]` to the new attribute parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-07-04T07:21:49Z

⌛ Testing commit fee5e3c with merge 1b61d43...

Rollup of 6 pull requests Successful merges: - rust-lang/rust#134006 (setup typos check in CI) - rust-lang/rust#142876 (Port `#[target_feature]` to new attribute parsing infrastructure) - rust-lang/rust#143038 (avoid suggesting traits from private dependencies) - rust-lang/rust#143083 (Fix rustdoc not correctly showing attributes on re-exports) - rust-lang/rust#143283 (document optional jobs) - rust-lang/rust#143329 (minicore: use core's `diagnostic::on_unimplemented` messages) Failed merges: - rust-lang/rust#143237 (Port `#[no_implicit_prelude]` to the new attribute parsing infrastructure) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-07-04T10:22:07Z

☀️ Test successful - checks-actions
Approved by: jdonszelmann,oli-obk
Pushing 1b61d43 to master...

github-actions · 2025-07-04T10:25:17Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c96a690 (parent) -> 1b61d43 (this PR)

Test differences

Show 1 test diff

1 doctest diff were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 1b61d43bdbf875183b1f436302d62ff93f9a6bba --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 9854.4s -> 7616.3s (-22.7%)
x86_64-apple-1: 9582.2s -> 7463.1s (-22.1%)
dist-armhf-linux: 4646.0s -> 5537.5s (19.2%)
aarch64-apple: 4304.1s -> 4982.1s (15.8%)
x86_64-apple-2: 5201.7s -> 4405.8s (-15.3%)
dist-aarch64-apple: 5455.0s -> 4739.7s (-13.1%)
dist-powerpc-linux: 4773.7s -> 5315.3s (11.3%)
dist-powerpc64le-linux-gnu: 4912.1s -> 5465.8s (11.3%)
dist-x86_64-mingw: 7188.4s -> 7969.6s (10.9%)
dist-armv7-linux: 4797.2s -> 5284.9s (10.2%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-07-04T14:05:17Z

Finished benchmarking commit (1b61d43): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.9%, 0.9%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -2.0%, secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-2.0%	[-2.0%, -2.0%]	1
Improvements ✅ (secondary)	-4.7%	[-7.2%, -2.2%]	2
All ❌✅ (primary)	-2.0%	[-2.0%, -2.0%]	1

Cycles

Results (secondary -4.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.5%	[0.5%, 2.3%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.9%	[-12.5%, -1.2%]	5
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 461.827s -> 462.82s (0.22%)
Artifact size: 372.20 MiB -> 372.13 MiB (-0.02%)

oli-obk · 2025-07-04T14:08:13Z

The CTFE regression is likely inliner noise, as it can't be related to this PR

rustbot assigned oli-obk Jun 30, 2025

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2025

JonathanBrouwer marked this pull request as ready for review June 30, 2025 14:09

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 30, 2025

JonathanBrouwer mentioned this pull request Jun 30, 2025

Port #[ignore] to the new attribute parsing infrastructure #143238

Open

JonathanBrouwer force-pushed the no_implicit_prelude_parser branch 2 times, most recently from 5172406 to a96330e Compare July 1, 2025 15:07

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2025

GuillaumeGomez mentioned this pull request Jul 1, 2025

Rollup of 12 pull requests #143287

Merged

JonathanBrouwer force-pushed the no_implicit_prelude_parser branch from a96330e to f793856 Compare July 1, 2025 22:15

JonathanBrouwer mentioned this pull request Jul 2, 2025

Port #[path] to the new attribute parsing infrastructure #143344

Open

JonathanBrouwer force-pushed the no_implicit_prelude_parser branch from f793856 to e27211a Compare July 3, 2025 05:50

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 3, 2025

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 3, 2025

This was referenced Jul 3, 2025

Tracking issue: Attribute refactor #131229

Open

Rollup of 6 pull requests #143362

Closed

Rollup of 6 pull requests #143363

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 3, 2025

Port #[no_implicit_prelude] to the new attribute parsing infrastruc…

fee5e3c

…ture Signed-off-by: Jonathan Brouwer <[email protected]>

JonathanBrouwer force-pushed the no_implicit_prelude_parser branch from e27211a to fee5e3c Compare July 3, 2025 19:01

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 3, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 3, 2025

jdonszelmann mentioned this pull request Jul 4, 2025

Port #[rustc_pass_by_value] to the new attribute system #143400

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 4, 2025

bors merged commit 1b61d43 into rust-lang:master Jul 4, 2025
12 checks passed

rustbot added this to the 1.90.0 milestone Jul 4, 2025

Port #[no_implicit_prelude] to the new attribute parsing infrastructure #143237

Port #[no_implicit_prelude] to the new attribute parsing infrastructure #143237

Conversation

JonathanBrouwer commented Jun 30, 2025

Uh oh!

rustbot commented Jun 30, 2025

Uh oh!

oli-obk commented Jul 1, 2025

Uh oh!

bors commented Jul 1, 2025

Uh oh!

JonathanBrouwer commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oli-obk commented Jul 2, 2025

Uh oh!

bors commented Jul 2, 2025

Uh oh!

GrigorenkoPV commented Jul 2, 2025

Uh oh!

JonathanBrouwer commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oli-obk commented Jul 3, 2025

Uh oh!

bors commented Jul 3, 2025

Uh oh!

jdonszelmann commented Jul 3, 2025

Uh oh!

jdonszelmann commented Jul 3, 2025

Uh oh!

bors commented Jul 3, 2025

Uh oh!

JonathanBrouwer commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdonszelmann commented Jul 3, 2025

Uh oh!

bors commented Jul 3, 2025

Uh oh!

jdonszelmann commented Jul 3, 2025

Uh oh!

bors commented Jul 3, 2025

Uh oh!

bors commented Jul 3, 2025

Uh oh!

jdonszelmann commented Jul 3, 2025

Uh oh!

bors commented Jul 4, 2025

Uh oh!

bors commented Jul 4, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 4, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jul 4, 2025

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

oli-obk commented Jul 4, 2025

Uh oh!

Uh oh!

Port `#[no_implicit_prelude]` to the new attribute parsing infrastructure #143237

Port `#[no_implicit_prelude]` to the new attribute parsing infrastructure #143237

JonathanBrouwer commented Jul 1, 2025 •

edited

Loading

JonathanBrouwer commented Jul 3, 2025 •

edited

Loading

JonathanBrouwer commented Jul 3, 2025 •

edited

Loading