-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Fix x86_64-unknown-netbsd
platform support page
#143566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`x86_64-unknown-netbsd` is Tier 2 with host tools, not Tier 3.
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that in the target maintainer section, there's a broken link:
Further contacts:
- NetBSD/pkgsrc-wip's rust maintainer (see MAINTAINER variable). This package is part of "pkgsrc work-in-progress" and is used for deployment and testing of new versions of rust
This file no longer exists. I assume it's no longer called rust185
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's called rust188
now. https://github.com/NetBSD/pkgsrc-wip/blob/master/rust188/Makefile says "[email protected]". That's probably too generic. @he32 we might need at least two maintainers for a Tier 2 target, could you give us contacts for two?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, yes, pkgsrc-users@ is the signal that "any of the ones with a commit bit and who has anything to contribute may do so", i.e. a more lenient policy than explicitly having to pass any updates under a specific developer's nose.
We have discussed this a bit, and you may enlist @0323pin as an additional maintainer of our amd64 / x86_64 target.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that in the target maintainer section, there's a broken link:
Further contacts:
- NetBSD/pkgsrc-wip's rust maintainer (see MAINTAINER variable). This package is part of "pkgsrc work-in-progress" and is used for deployment and testing of new versions of rust
This file no longer exists. I assume it's no longer called
rust185
?
Hm, yes, sorry about that. We have come to adopt the convention that we may have more than one rust version active in pkgsrc-wip at any time, and as such use the rust version as part of the directory name. From time to time we import a new version to pkgsrc proper, where rust has an un-versioned directory name. So ... To reference a file in pkgsrc proper, the rust package can be found mirrored on https://github.com/NetBSD/pkgsrc/tree/trunk/lang/rust
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be happy to review a follow-up PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be happy to review a follow-up PR :)
@bors r+ rollup |
Rollup of 9 pull requests Successful merges: - #132469 (Do not suggest borrow that is already there in fully-qualified call) - #143340 (awhile -> a while where appropriate) - #143438 (Fix the link in `rustdoc.md`) - #143539 (Regression tests for repr ICEs) - #143566 (Fix `x86_64-unknown-netbsd` platform support page) - #143572 (Remove unused allow attrs) - #143583 (`loop_match`: fix 'no terminator on block') - #143584 (make `Machine::load_mir` infallible) - #143591 (Fix missing words in future tracking issue) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #143566 - jieyouxu:fix-x86_64-unknown-netbsd, r=fee1-dead Fix `x86_64-unknown-netbsd` platform support page `x86_64-unknown-netbsd` is Tier 2 with host tools, not Tier 3. cc `@he32.` r? compiler
Rollup of 9 pull requests Successful merges: - rust-lang/rust#132469 (Do not suggest borrow that is already there in fully-qualified call) - rust-lang/rust#143340 (awhile -> a while where appropriate) - rust-lang/rust#143438 (Fix the link in `rustdoc.md`) - rust-lang/rust#143539 (Regression tests for repr ICEs) - rust-lang/rust#143566 (Fix `x86_64-unknown-netbsd` platform support page) - rust-lang/rust#143572 (Remove unused allow attrs) - rust-lang/rust#143583 (`loop_match`: fix 'no terminator on block') - rust-lang/rust#143584 (make `Machine::load_mir` infallible) - rust-lang/rust#143591 (Fix missing words in future tracking issue) r? `@ghost` `@rustbot` modify labels: rollup
x86_64-unknown-netbsd
is Tier 2 with host tools, not Tier 3.cc @he32.
r? compiler