Clippy subtree update #143745
Merged
Clippy subtree update #143745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `TyCtxt::hir_get_fn_id_for_return_block()` function was too broad, as it will return positively even when given part of an expression that can be used as a return value. A new `potential_return_of_enclosing_body()` utility function has been made to represent the fact that an expression might be directly returned from its enclosing body.
This commit also adds more test cases, which work fine but were mentioned in the issue.
…links-expansion, r=lolbinarycat [rustdoc] Do not emit redundant_explicit_links lint if the doc comment comes from expansion Fixes rust-lang#141553. The problem was that we change the context for the attributes in some cases to get better error output, preventing us to detect if the attribute comes from expansion. Most of the changes are about keeping track of the "does this span comes from expansion" information. r? ```@Manishearth```
The lint was extra restrictive, and didn't suggest using `core::ptr::null` and `core::ptr::null_mut` in `const` contexts although they have been const-stabilized since Rust 1.24.
…=fee1-dead New const traits syntax This PR only affects the AST and doesn't actually change anything semantically. All occurrences of `~const` outside of libcore have been replaced by `[const]`. Within libcore we have to wait for rustfmt to be bumped in the bootstrap compiler. This will happen "automatically" (when rustfmt is run) during the bootstrap bump, as rustfmt converts `~const` into `[const]`. After this we can remove the `~const` support from the parser Caveat discovered during impl: there is no legacy bare trait object recovery for `[const] Trait` as that snippet in type position goes down the slice /array parsing code and will error r? ``@fee1-dead`` cc ``@nikomatsakis`` ``@traviscross`` ``@compiler-errors``
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#139858 (New const traits syntax) - rust-lang#140809 (Reduce special casing for the panic runtime) - rust-lang#142730 (suggest declaring modules when file found but module not defined) - rust-lang#142806 (Normalize before computing ConstArgHasType goal in new solver) - rust-lang#143046 (const validation: properly ignore zero-sized UnsafeCell) - rust-lang#143092 (const checks for lifetime-extended temporaries: avoid 'top-level scope' terminology) - rust-lang#143096 (tag_for_variant: properly pass TypingEnv) - rust-lang#143104 (hir_analysis: prohibit `dyn PointeeSized`) - rust-lang#143106 (gce: don't ICE on non-local const) Failed merges: - rust-lang#143036 (Remove support for `dyn*` from the compiler) r? `@ghost` `@rustbot` modify labels: rollup
The lint was extra restrictive, and didn't suggest using `core::ptr::null` and `core::ptr::null_mut` in `const` contexts although they have been const-stabilized since Rust 1.24. changelog: [`zero_ptr`]: lint in `const` context as well @rustbot label +I-false-negative +C-bug
…15123) Closes rust-lang/rust-clippy#15116 The cause for this issue is that `_` belongs to the `Common` catagory in unicode instead of `Latin` like other ASCII alphabets. Since ASCII characters are always allowed, I just added an extra `is_ascii()` check to ensure this. changelog: [`disallowed_script_idents`] fix FP on identifiers with `_`
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
|
Ah So we do need rust-lang/rust-clippy#15255 in this PR, it can't land separately. |
RalfJung
force-pushed
the
clippy-subtree-update
branch
from
4bc379d to
a0a8e80
Compare
rustbot
added
S-waiting-on-review
|
The Miri subtree was changed cc @rust-lang/miri |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Yes, should be good now. Thanks for looking into and fixing this @RalfJung ! (Just got back from my long weekend vacation) |
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors p=1 subtree sync |
|
@Manishearth Given that this PR also touches dependencies and workspaces, maybe it would be safer to make it rollup=never |
|
@bors rollup=never |
Kobzol
added a commit
to Kobzol/rust
that referenced
this pull request
Jul 14, 2025
…Manishearth Clippy subtree update r? `@Manishearth` Cargo.lock update due to `ui_test` bump and restructure.
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing aa51a9b (parent) -> a001497 (this PR) Test differencesNo test diffs found Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a001497644bc229f1abcc5b2528733386591647f --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (a001497): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary 2.9%, secondary 2.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 463.338s -> 464.247s (0.20%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Manishearth
Cargo.lock update due to
ui_testbump and restructure.