Rename stable_mir and rustc_smir
#143848
Merged
Rename stable_mir and rustc_smir
#143848
+277
−267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-meta
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged.
|
rust-cloud-vms
bot
force-pushed
the
smir-rename
branch
from
3566674 to
ca3d199
Compare
oli-obk
reviewed
Jul 14, 2025
|
considering the crate hosts the |
I'd say this one is better^^ |
rust-cloud-vms
bot
force-pushed
the
smir-rename
branch
from
ca3d199 to
acf5795
Compare
|
Actually there are still bunches of docs, struct names and directory names that need updating. I'd like to do these changes as follow-ups for better clarity. |
rust-cloud-vms
bot
force-pushed
the
smir-rename
branch
from
acf5795 to
6598c61
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 14, 2025
Rollup of 8 pull requests Successful merges: - #141809 (Don't call WSACleanup on process exit) - #143710 (Updates to random number generation APIs) - #143848 (Rename `stable_mir` and `rustc_smir`) - #143855 (Port `#[omit_gdb_pretty_printer_section]` to the new attribute parsing) - #143868 (warn on align on fields to avoid breaking changes) - #143870 ([COMPILETEST-UNTANGLE 6/N] Use `TestSuite` enum instead of stringly-typed test suites) - #143901 (Region constraint nits) - #143903 (Fix typos in documentation files) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jul 14, 2025
Rollup merge of #143848 - makai410:smir-rename, r=oli-obk Rename `stable_mir` and `rustc_smir` This PR only renames the two crate names. There is no doubt that we want to rename `stable_mir` to `rustc_public`, while it hasn't been discussed yet that what the new name for `rustc_smir` should be. This PR proposes a new name for `rustc_smir`, that is `rustc_public_shim`, since `rustc_smir` now is mostly a proxy to do calls to rustc queries and the public API of rustc that is invoked by the `rustc_public` crate. However, I don't think that name is good enough. I hope there would be a way better name. r? `@oli-obk`
github-actions bot
pushed a commit
to devnexen/miri
that referenced
this pull request
Jul 15, 2025
Rollup of 8 pull requests Successful merges: - rust-lang/rust#141809 (Don't call WSACleanup on process exit) - rust-lang/rust#143710 (Updates to random number generation APIs) - rust-lang/rust#143848 (Rename `stable_mir` and `rustc_smir`) - rust-lang/rust#143855 (Port `#[omit_gdb_pretty_printer_section]` to the new attribute parsing) - rust-lang/rust#143868 (warn on align on fields to avoid breaking changes) - rust-lang/rust#143870 ([COMPILETEST-UNTANGLE 6/N] Use `TestSuite` enum instead of stringly-typed test suites) - rust-lang/rust#143901 (Region constraint nits) - rust-lang/rust#143903 (Fix typos in documentation files) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only renames the two crate names.
There is no doubt that we want to rename
stable_mirtorustc_public, while it hasn't been discussed yet that what the new name forrustc_smirshould be.This PR proposes a new name for
rustc_smir, that isrustc_public_shim, sincerustc_smirnow is mostly a proxy to do calls to rustc queries and the public API of rustc that is invoked by therustc_publiccrate.However, I don't think that name is good enough. I hope there would be a way better name.
r? @oli-obk