Skip to content

ci: use windows 22 for all free runners #144069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcoieni
Copy link
Member

As discussed in #t-infra > windows-2025 image, the windows 25 image has fewer disk space than the windows 22 image. So we are moving CI to use windows 22, at least for the free runners.

try-job: x86_64-msvc-*

@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 17, 2025
@marcoieni
Copy link
Member Author

@bors2 try

rust-bors bot added a commit that referenced this pull request Jul 17, 2025
ci: use windows 22 for all free runners

<!-- homu-ignore:start -->
<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.

This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using

    r? <reviewer name>
-->
As discussed in [#t-infra > windows-2025 image](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/windows-2025.20image/with/529269980), the windows 25 image has fewer disk space than the windows 22 image. So we are moving CI to use windows 22, at least for the free runners.
<!-- homu-ignore:end -->
try-job: `x86_64-msvc-*`
@rust-bors
Copy link

rust-bors bot commented Jul 17, 2025

⌛ Trying commit 232c5de with merge 5cc6bab

To cancel the try build, run the command @bors2 try cancel.

@jieyouxu
Copy link
Member

Thanks, r=me if try job is green. This is going to be a temporary mitigation, but better than nothing. In the LLVM PR, looks like (current) Windows Server 2022 images

Image: windows-2022
Version: 20250710.1.0

do have more disk space because, well, the D: drive still exists.

 Filesystem            Size  Used Avail Use% Mounted on
C:/Program Files/Git  256G  161G   96G  63% /
D:                    150G   11G  140G   8% /d

@jieyouxu jieyouxu assigned jieyouxu and unassigned Mark-Simulacrum Jul 17, 2025
@jieyouxu
Copy link
Member

Looks like 2022 images still have the D: drive and thus more disk space.

I hope they're not somehow flaky 😅

@rust-bors
Copy link

rust-bors bot commented Jul 17, 2025

☀️ Try build successful (CI)
Build commit: 5cc6bab (5cc6babcbcdca57c4f616b9f09f1610cdbbf79df, parent: 8c12d76304fcceaeaad0d67209e5727e94f5f2b8)

@marcoieni
Copy link
Member Author

@bors r=jieyouxu

@bors
Copy link
Collaborator

bors commented Jul 17, 2025

📌 Commit a886852 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2025
Kobzol added a commit to Kobzol/rust that referenced this pull request Jul 17, 2025
ci: use windows 22 for all free runners

try-job: `x86_64-msvc-*`
bors added a commit that referenced this pull request Jul 18, 2025
Rollup of 10 pull requests

Successful merges:

 - #142300 (Disable `tests/run-make/mte-ffi` because no CI runners have MTE extensions enabled)
 - #143649 (Add test for `default_field_values` and `const_default`)
 - #144010 (Boostrap: add warning on `optimize = false`)
 - #144029 (Fix wrong messages from methods with the same name from different traits)
 - #144049 (rustc-dev-guide subtree update)
 - #144053 (Remove install Rust script from CI)
 - #144056 (Copy GCC sources into the build directory even outside CI)
 - #144063 (Add myself to the `infra-ci` reviewer group and adjust some infra auto-labels)
 - #144069 (ci: use windows 22 for all free runners)
 - #144083 (miri sleep tests: increase slack)

r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 18, 2025
ci: use windows 22 for all free runners

try-job: `x86_64-msvc-*`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 18, 2025
ci: use windows 22 for all free runners

try-job: `x86_64-msvc-*`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 18, 2025
ci: use windows 22 for all free runners

try-job: `x86_64-msvc-*`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 18, 2025
ci: use windows 22 for all free runners

try-job: `x86_64-msvc-*`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants