Rollup of 5 pull requests #144891
Closed
Rollup of 5 pull requests #144891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- All settings are now phrased in the imperative form stating what the setting does rather than talking about what it controls. (E.g.: "Show `Debug` action." instead of "Whether to show `Debug` action" - Categories are now displayed in title case - Categories are now sorted lexicographically - General category is removed (and all the settings are moved to the top level) - Language for a few descriptions is made a bit less ambiguous
And add assert_eq, assert_ne, assert_matches support
Input:
```rust
pub fn $0foo(x: bool) {
debug_assert!(x);
}
```
Old:
```rust
/// .
///
/// # Panics
///
/// Panics if .
pub fn foo(x: bool) {
debug_assert!(x);
}
```
This PR fixes:
```rust
/// .
pub fn foo(x: bool) {
debug_assert!(x);
}
```
Signed-off-by: Hayashi Mikihiro <[email protected]>
…` to SyntaxEditor Signed-off-by: Hayashi Mikihiro <[email protected]>
…ditor' Signed-off-by: Hayashi Mikihiro <[email protected]>
…-gen Fix gen panics doc template for debug_assert
fix: Do not require all rename definitions to be renameable
Use GH app for authenticating sync PRs
…t support snippets
…l-snippet fix: In generate_mut_trait_impl, don't add a tabstop if the client does not support snippets
Improve settings tree title and descriptions
… `impl Trait`, collect only the bounds of this projection It used to collect the bounds of them all.
…hints fix: When displaying a projection into a type parameter that has bounds as `impl Trait`, collect only the bounds of this projection
…le_struct_to_named_struct Migrate `convert_tuple_struct_to_named_struct` assist to use `SyntaxEditor`
…_alias_to_syntax_editor Migrate `inline_type_alias` assist to use `syntax_editor`
Reorganize proc-macro-srv more, add `--format` and `--version` args
`cargo clippy --fix`
…ssoc_items_to_impl add `SyntaxEditor::delete_all` to migrate utils.rs `add_trait_assoc_items_to_impl`
…ait_from_impl Migrate `generate_trait_from_impl` assist to use `SyntaxEditor`
…om_edit_in_place Remove unused functions from edit_in_place.rs
… r=fee1-dead fix: Error on illegal `[const]`s inside blocks within legal positions Fixes rust-lang#132067 I initially considered moving `[const]` validations to `rustc_ast_lowering`, but that approach would require adding constness information to `AssocCtxt`, which introduces significant changes - especially within `rustc_expand` - just to support a single use case here: https://github.com/rust-lang/rust/blob/3fb1b53a9dbfcdf37a4b67d35cde373316829930/compiler/rustc_ast_passes/src/ast_validation.rs#L1596-L1610 Instead, I believe it's sufficient to simply "reset" `[const]` allowness whenever we enter a new block.
Implement debugging output of the bootstrap Step graph into a DOT file There are already a bunch of ways how we can debug bootstrap, so why not add one more =D (ideally I'd like to consolidate these approaches somewhat, `@Shourya742` is looking into that, but I think that this specific debugging tool is orthogonal to the rest of them, and is quite useful). This PR adds the option to render the bootstrap step graph into the DOT format, in order to understand what steps were executed, along with their fields (`Debug` output). Here you can see an example of the generated DOT files for the `BOOTSTRAP_TRACING=1 ./x build compiler --stage 2 --dry-run` command on x64 Linux. One is with cached deps (what this PR does), the other one without. [bootstrap-dot.zip](https://github.com/user-attachments/files/21548679/bootstrap-dot.zip) Visual example: <img width="1899" height="445" alt="image" src="https://github.com/user-attachments/assets/ae40e6d2-0ea8-48bb-b77e-6b21700b95ee" /> r? `@jieyouxu`
Add a tidy check to prevent adding UI tests directly under `tests/ui/` This PR implements rust-lang/compiler-team#902. Only the last commit (adding the new check) is functional; earlier commits are just small drive-by changes to make the other ui/ui-fulldeps checks more logically contained. r? `@Kobzol` (or compiler)
…=jdonszelmann Remove `SHOULD_EMIT_LINTS` in favor of `should_emit` r? `@jdonszelmann`
`rust-analyzer` subtree update Subtree update of `rust-analyzer` to rust-lang/rust-analyzer@8d75311. Created using https://github.com/rust-lang/josh-sync. r? `@ghost`
rustbot
added
A-attributes
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 4, 2025
Rollup of 5 pull requests Successful merges: - #144741 (fix: Error on illegal `[const]`s inside blocks within legal positions) - #144779 (Implement debugging output of the bootstrap Step graph into a DOT file) - #144813 (Add a tidy check to prevent adding UI tests directly under `tests/ui/`) - #144866 (Remove `SHOULD_EMIT_LINTS` in favor of `should_emit`) - #144887 (`rust-analyzer` subtree update) r? `@ghost` `@rustbot` modify labels: rollup
|
@bors retry (yield to stable release) |
|
Release jobs will take a while, so let's delete this rollup and make a bigger one later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
[const]s inside blocks within legal positions #144741 (fix: Error on illegal[const]s inside blocks within legal positions)tests/ui/#144813 (Add a tidy check to prevent adding UI tests directly undertests/ui/)SHOULD_EMIT_LINTSin favor ofshould_emit#144866 (RemoveSHOULD_EMIT_LINTSin favor ofshould_emit)rust-analyzersubtree update #144887 (rust-analyzersubtree update)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup