Improve docs on JSON #15675
Merged
Improve docs on JSON #15675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| This examples above uses the `ToJson` trait to generate the JSON string, required for custom mappings. | ||
|
|
||
| ### Simle example of `ToJson` usage |
|
Fix the line length issue that Travis complained about. |
| ## Using `ToJson` | ||
| ## Using the `ToJson` trait | ||
|
|
||
| The examples above uses the `ToJson` trait to generate the JSON string, required for custom |
There was a problem hiding this comment.
and also "string, which is required"
|
lgtm after those two tiny changes. |
- add one simple example of using `ToJson` trait - make example code more readable
|
@steveklabnik thanks for paying attention to my typos, I fixed them now :) |
|
@alexcrichton I don't seem to see an error. There are some warning though, but all changes here are in comments... Any ideas? |
|
It looks like a spurious failure, and @huonw write |
bors
added a commit
that referenced
this pull request
Jul 17, 2014
- add one simple example of using `ToJson` trait - make example code more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToJsontrait