Add accessors for io::Error's inner Error #25816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This all looks good to me, with downcasting on Can you add some tests which exercise the downcasting and the various accessors? |
error::Error itself has downcasting methods, so there's no need to duplicate those here.
Ergonomics are a bit crappy right now because method resolution isn't smart enough to drop bounds, unfortunately.
sfackler
force-pushed
the
io-error-delegation
branch
from
1695200 to
f65ba38
Compare
|
Updated |
|
Could you add "requires UFCS to downcast" to one of the |
|
⌛ Testing commit aebf331 with merge 9befda2... |
|
💔 Test failed - auto-linux-64-nopt-t |
|
@bors: retry On Thu, May 28, 2015 at 1:16 PM, bors [email protected] wrote:
|
bors
added a commit
that referenced
this pull request
May 29, 2015
The first commit simply forwards `io::Error`'s `cause` implementation to the inner error. The second commit adds accessor methods for the inner error. Method names mirror those used elsewhere like `BufReader`. r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit simply forwards
io::Error'scauseimplementation to the inner error.The second commit adds accessor methods for the inner error. Method names mirror those used elsewhere like
BufReader.r? @alexcrichton