Fully generalize BTree{Map, Set} range iterators
#27545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have one more commit incoming that simplifies one of the doc examples based on this. |
This permits collections with `String` keys to be ranged over with
`&str` bounds. The `K` defaults for `Min` and `Max` permit the default
type parameter fallback to work with things like
```rust
use std::collections::{BTreeSet, Bound};
let set = BTreeSet::<String>::new();
set.range(Bound::Included("a"), Bound::Unbounded);
```
Without the defaults, the type of the maximum bound would be
unconstrained.
|
Rebased. |
|
I favour pushing as much as possible into the where clauses, but I understand this is kinda a lost cause because of ?Sized stuff. |
|
(Is that example thing rebased in, or still coming..?) |
|
Yeah the example was updated to remove extra indirections from the strings. On Wednesday, August 5, 2015, Alexis Beingessner [email protected]
|
|
@bors r+ Thanks! |
|
📌 Commit 4fdeb35 has been approved by |
|
⌛ Testing commit 4fdeb35 with merge 4278b5f... |
bors
added a commit
that referenced
this pull request
Aug 6, 2015
This permits collections with `String` keys to be ranged over with
`&str` bounds. The `K` defaults for `Min` and `Max` permit the default
type parameter fallback to work with things like
```rust
use std::collections::{BTreeSet, Bound};
let set = BTreeSet::<String>::new();
set.range(Bound::Included("a"), Bound::Unbounded);
```
Without the defaults, the type of the maximum bound would be
unconstrained.
r? @gankro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This permits collections with
Stringkeys to be ranged over with&strbounds. TheKdefaults forMinandMaxpermit the defaulttype parameter fallback to work with things like
Without the defaults, the type of the maximum bound would be
unconstrained.
r? @gankro