-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Improve docs in os::windows::ffi and os::windows::fs #41870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
db16ca7
Update documention in windows::ffi
randomPoison e406cd1
Update documentation in windows::ffi
randomPoison d7df6dc
Merge remote-tracking branch 'rust-lang/master' into iss29367-windows…
randomPoison 76128b3
Update documentation in windows::fs
randomPoison c350bc1
Fix documentation tests in windows::fs
randomPoison 5135cc8
Fix tidy errors
randomPoison 4cd838b
Normalize docs in windows::ffi and windows::fs
randomPoison a892925
Fix doc test failure for OpenOptionsExt
randomPoison File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor, but can you remove all the
()
parens attached to method/function names in these docs? for the time being, the current policy is to remove them in documentation. see also #40456There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I was under the impression that the
()
parens were the desired style, thanks for clarifying that this isn't the case (I can update documentation for my own crates as well).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my own curiosity, is there some discussion around why the decision was made to remove the
()
parens when referencing function in documentation? Personally I liked that style, so I'm curious as to why the change was made.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't that a change was made; it was that while proposing https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md, we suggested that style, but it didn't make it through the process.
(I really like the
()
s so I was just adding them in before we had an actual convention)