Skip to content

Fix issue 'double spaces between struct field prefix and identity when using long attributes #4747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

whizsid
Copy link
Contributor

@whizsid whizsid commented Mar 9, 2021

Fixes #4671 .

Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks like you've definitely zeroed in on the problem area, though I'd like to tweak the fix a bit

Comment on lines +1 to +5
struct X<'a>(
#[X(X = "_________________________________________________________________________")]
pub &'a u32,
// ^^
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a snippet to this file that includes one that starts with the double space too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would've been a nice to have but not necessary, will go ahead and merge

@calebcartwright
Copy link
Member

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double Space between pub & when preceeded by long attribute
3 participants