Skip to content

Move Text from Embedded page into Translation Files #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 28, 2019

Conversation

eignnx
Copy link
Contributor

@eignnx eignnx commented May 27, 2019

Work for #798

The webpage has been visually inspected side-by-side with the live site, and no differences have been found. I compared:

  • Link hrefs
  • Paragraph wrap and spacing
  • Image alt text

@eignnx eignnx changed the title [WIP] Move Text from Embedded page into Translation Files Move Text from Embedded page into Translation Files May 27, 2019
@eignnx
Copy link
Contributor Author

eignnx commented May 27, 2019

@Manishearth ready for review

@Manishearth Manishearth merged commit 3ef4cb3 into rust-lang:i18n May 28, 2019
Manishearth added a commit that referenced this pull request May 28, 2019
Move Text from Embedded page into Translation Files
@eignnx eignnx deleted the i18n-embedded branch May 28, 2019 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants