urldecode fix and path mapping (for docker/devilbox) #19
Conversation
added in server path replacement for docker/devilbox
| find="/shared/httpd/" | ||
| replace="/home/michael/public_html/"; |
There was a problem hiding this comment.
Isn't the path mapping something, that should be handled on the application side, that builds the links?
There was a problem hiding this comment.
possibly and some apps might already have this. the software i usually develop in for web applications, doesn't have it, so i added it for my own use, but decided to keep it for this PR in case anyone else needed it.
There was a problem hiding this comment.
I see. Maybe you can also make a note in the README.md so that the user is aware of such functionality.
There was a problem hiding this comment.
I'm not too keen on putting those hard coded variables into the executable.
Might be doable via environment variables, though.
README.md
Outdated
| find="/shared/httpd/" | ||
| replace="/home/michael/public_html/"; |
There was a problem hiding this comment.
Both of these lines show on the single line after README is rendered. This is how you planned this to be?
|
@codingjungle , I've approved my review. Let's see what @sanduhrs will think about this. |
|
Could this be merged and released maybe? I really miss the url encode to let it work locally now |
|
A fix for the urlencoding has been committed e46793a |
Nice! With the latest aur release it all works again! Thanks a lot! |
the link in linux gets url encoded, this will decode it and allow it to work.
also has a path mapping, so you can replace a docker/devilbox path to map to the location on your drive.