Skip to content

Consolidate PRs 97 & 100 then run both through current CI #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

LeeTibbert
Copy link
Contributor

@LeeTibbert LeeTibbert commented Jul 16, 2025

Reduce accumulated clutter: Consolidate and superseded PRs 97 & 100 then run through current CI.

This should make it easier for both humans and scala-steward to figure out the current & pending states.

The superseded PRs can be closed after this PR is merged.

This was referenced Jul 16, 2025
@ekrich
Copy link
Member

ekrich commented Jul 16, 2025

Maybe you should consider adding dependabot.yml copied from Scala Native too. That won't help for platform deprecations but the other dependencies in the github actions.

@LeeTibbert
Copy link
Contributor Author

LeeTibbert commented Jul 16, 2025

Rebased & passing.

@LeeTibbert
Copy link
Contributor Author

Eric,

Good idea. I'll try to do it in a separate PR, if I do not run out of time.

I am currently working on the one outstanding issue: adding CLA & scalafmt to
this repository. Let me see how that work goes.

@ekrich
Copy link
Member

ekrich commented Jul 16, 2025

It is just copying that one file from Native to Native.g8 - figured you were just trying to clean up all the PRs.

@LeeTibbert
Copy link
Contributor Author

It is just copying that one file from Native to Native.g8 - figured you were just trying to clean up all the PRs.

You surmised correctly. I am trying to clean up the one Issue and at least get the PRs sorted and minimal.

I figure that will make changing an merging easier. Introducing a bit of automation will help also.

It is just copying that one file from Native to Native.g8

Whenever I hear or see the words "just" or "simply", I cower and run for the hills. I figure that I am
in for a Big Time hosing.

More seriously, there is only so much complexity that my brain can handle, especially when things
that are supposed to be "just" go wrong. CI needs it belly stroked "just so".

The two changes seem to have succeeded. I'm off to see if adding dependabot goes smoothly.

@LeeTibbert LeeTibbert force-pushed the PR_July16_ConsolidateOutstandingPRs_2025 branch from f1d472a to 15d7e6f Compare July 17, 2025 10:48
@LeeTibbert
Copy link
Contributor Author

I fixed the broken build.properties cruft that had snuck in during a rebase. Sorry, for the
wasted time. Changed files look good & current now.

All Green & ready.

@WojciechMazur WojciechMazur merged commit 30f6f04 into scala-native:main Jul 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants