Skip to content

Fixed typos and broken link. #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2014
Merged

Conversation

gkossakowski
Copy link
Contributor

We had some missing parenthesis. Also, a link to JIRA contained parenthesis
which confused Markdown renderer. We use hex escapes for ( and ) characters
instead.

@gkossakowski
Copy link
Contributor Author

Review by @sjrd or @adriaanm.

@@ -14,12 +14,12 @@ Scala 2.11.4 is a bugfix release that is binary compatible with previous release
The changes include:

* Scala shell (REPL) is more friendly to Crtl+D. It leaves your terminal in a clean state and suggests using `:quit` the next
time (see [#3902](https://github.com/scala/scala/pull/3902). Kudos to [@gourlaysama](https://github.com/gourlaysama)!
time (see [#3902](https://github.com/scala/scala/pull/3902)). Kudos to [@gourlaysama](https://github.com/gourlaysama)!
* REPL uses different colors when printing references to vals and types. Pass `-Dscala.color` to enable that behavior (see [#3993](https://github.com/scala/scala/pull/3993)). Thanks to [@puffnfresh](https://github.com/puffnfresh)!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does -Dscala.color work for you? I had to use -Dscala.color=1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does.

We had some missing parenthesis. Also, a link to JIRA contained parenthesis
which confused Markdown renderer. We use hex escapes for ( and ) characters
instead.
@adriaanm
Copy link
Contributor

LGTM

gkossakowski added a commit that referenced this pull request Oct 31, 2014
@gkossakowski gkossakowski merged commit 30cd16d into scala:master Oct 31, 2014
@gkossakowski gkossakowski deleted the fix-typos branch October 31, 2014 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants