Ycheck that all methods have method type #1205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why does this fail? |
|
Some tests failed related to the tree checking in this commit. I'll investigate. Most likely I missed some valid types here. |
| @@ -237,6 +237,14 @@ class TreeChecker extends Phase with SymTransformer { | |||
| tree | |||
| } | |||
|
|
|||
| /** Check that all methods have either MethodicType or PolyType(MethodicType) */ | |||
| def isMethodType(pt: Type)(implicit ctx: Context): Boolean = pt match { | |||
There was a problem hiding this comment.
Failing tests suggest that you may be missing AnnotatedTypes here.
There was a problem hiding this comment.
Thanks @DarkDimius , AnnotatedType is indeed missing here. But there's something more related to default parameters.
Following generated function for default parameters
def copy$default$1[a]: a @uncheckedVariance =
Some.this.x: a @uncheckedVariance
gets following type:
PolyType(List(a), List(TypeBounds(TypeRef(ThisType(TypeRef(NoPrefix,scala)),Nothing), TypeRef(ThisType(TypeRef(NoPrefix,scala)),Any))), AnnotatedType(TypeRef(ThisType(TypeRef(ThisType(TypeRef(NoPrefix,<empty>)),Some)),Some$$a),ConcreteAnnotation(Apply(Select(New(TypeTree[TypeRef(ThisType(TypeRef(NoPrefix,unchecked)),uncheckedVariance)]),<init>),List()))))
Is it valid for methods of default parameters to take a non-method type?
liufengyun
force-pushed
the
method-check
branch
from
f11e850 to
60a0438
Compare
This was referenced Apr 11, 2016
liufengyun
force-pushed
the
method-check
branch
from
60a0438 to
cf50b72
Compare
|
retest this please |
liufengyun
force-pushed
the
method-check
branch
from
cf50b72 to
371e8a7
Compare
|
LGTM |
OlivierBlanvillain
pushed a commit
to OlivierBlanvillain/dotty
that referenced
this pull request
Dec 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1046 . Please review @DarkDimius .