Revise capability hierarchy and fix classifiers #23656
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is ready for review now. |
Linyxus
reviewed
Aug 5, 2025
library/src/scala/caps/package.scala
Outdated
| trait ExclusiveCapability extends Capability, Classifier | ||
|
|
||
| @experimental | ||
| type Exclusive = SharedCapability |
We now always give a reason in a TypeMismatch about which capture set inclusion failed.
Include result capabilities unless they are bound in the result.
Now we also report on level and classifier errors when comparing with FreshCaps.
Make reach improvement also dependent on migthSubCapture
- fix tryClassify and trsnaClassifiers for core capabilities - freeze classifications of FreshCaps in constant sets
- two subtraits: SharedCapability and ExclusiveCapability
Pre-type closure bodies with expected result type if expected type is a parametric function. This avoids turning fresh caps in their result type into result caps
For capabilities classified as Shared, assume `cap` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now make
Capabilitya sealed trait with two subtraits:SharedCapabilityandExclusiveCapability. This forces one to pick one or the other when defining a newCapabilitytype. Most tests were changed to useSharedCapabilityinstead ofCapability. Since classifiers are now much more common than before, this showed up some bugs and anomalies for classifyer handling, which are also addressed in this PR.Details:
captureSetOfInfo. During experimentation I found that sometimescaptureSetOfInfocould be cached too early, leading to a locked in universal cap in the info where we would expect to see a fresh cap. On the standard library it did not look like this had a noticeable performance impact.tryClassifyAsandtransClassifiers. In particular, we need to distinguishFreshCaps that can still be classified from ones that cannot. Once aFreshCapis part of a constant capture set, it gets classified by the type that prefixes the set and that classification cannot be changed anymore. But otherFreshCaps are created as members of variable sets and then their classification status is open and can be constrained further.cap.rdas implicitly added capability only for references extendingExclusiveCapability. Usecapfor the others.We also include now captures in the result type of a function in the
captureSetofInfoof that function.