Revert "feat: add pycln as a recommendation" #163
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4981ece.
|
The next release will ease up on the version restriction. It's <4 instead of open due to Poetry's infectious version capping system, but as a practical matter, I think it's okay. |
|
BTW, now all Python3 versions are supported until Python4: |
|
I'm happy that this won't happen again unless there's an actual code issue (which is totally fine and could happen to anyone). Let's keep the recommendation. Thanks! ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #154, removes pycln as a recommendation, due to hadialqattan/pycln#81. I'm sorry for the issue; I usually check dependencies and adding an upper cap is a huge red flag for me, especially on Python version, but I never checked this one.