[CI] Migrate CI to GitHub actions #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #166 +/- ##
==========================================
- Coverage 95.45% 91.94% -3.52%
==========================================
Files 7 7
Lines 484 484
Branches 99 99
==========================================
- Hits 462 445 -17
- Misses 15 22 +7
- Partials 7 17 +10
|
elacuesta
changed the title
elacuesta
commented
Mar 10, 2021
Comment on lines
+339
to
+345
| @pytest.mark.xfail(reason="https://github.com/scrapy/w3lib/issues/164") | ||
| def test_add_or_replace_parameter_fail(self): | ||
| self.assertEqual( | ||
| add_or_replace_parameter('http://domain/test?arg1=v1;arg2=v2', 'arg1', 'v3'), | ||
| 'http://domain/test?arg1=v3&arg2=v2' | ||
| ) | ||
|
|
There was a problem hiding this comment.
Just a temporary workaround to avoid having the workflows fail (#164)
Gallaecio
approved these changes
Mar 10, 2021
wRAR
reviewed
Mar 11, 2021
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-20.04 | ||
| strategy: | ||
| matrix: | ||
| python-version: [2.7, 3.5, 3.6, 3.7, 3.8, pypy3] |
There was a problem hiding this comment.
What does this change mean in practice (some versions are dropped)?
There was a problem hiding this comment.
Versions in this file are indicated along job definitions under include.
But these versions have actually been moved to the new tests.yml file. This file is now only for static tests (maybe Build is not the best name, Check as we use in Scrapy is slightly better).
wRAR
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Scrapy's config.
This will need a
PYPI_TOKENrepository secret to be set. Publishing to PyPI is working against the testing instance (see https://test.pypi.org/project/w3lib/, pushed from https://github.com/elacuesta/w3lib/runs/2078491608)