Add support for time-0.2 types #580
Conversation
postgres-types/src/lib.rs
Outdated
| @@ -391,6 +397,10 @@ impl WrongType { | |||
| /// | `chrono::DateTime<FixedOffset>` | TIMESTAMP WITH TIME ZONE | | |||
| /// | `chrono::NaiveDate` | DATE | | |||
| /// | `chrono::NaiveTime` | TIME | | |||
| /// | `time::PrimitiveDateTime` | TIMESTAMP | | |||
| /// | `time::OffsetDateTime` | TIMESTAMP, TIMESTAMP WITH TIME ZONE | | |||
There was a problem hiding this comment.
I think this should only support TIMESTAMP WITH TIME ZONE to align with chrono.
There was a problem hiding this comment.
Chrono's types embed specific timezones (or rather UTC vs Local) where as OffsetDateTime doesn't have the generic component and is compatible with both TIMESTAMP and TIMESTAMPZ. I'd prefer to be able to use OffsetDateTime with TIMESTAMP.
There was a problem hiding this comment.
I'd prefer to be able to use OffsetDateTime with TIMESTAMP.
With cockroach TIMESTAMP will always be UTC. I'm still looking for clarification on postgres's behavior. I think with the fact that we're explicitly setting the session to UTC, it should be OK either way.
There was a problem hiding this comment.
@sfackler I thought about this some more and came to the same conclusion. OffsetDateTime now only supports TIMESTAMPTZ in the latest commit. Do you want me to squash these commits?
|
Can you add tests as well? |
Ah! I just found the type tests under |
|
No need to squash! |
|
Thanks! |
This is essentially ported from the
chronoimplementation.