-
Notifications
You must be signed in to change notification settings - Fork 167
Build linux and windows amd64 agent bundles #2649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e8982af
to
309e411
Compare
atoulme
reviewed
Mar 6, 2023
309e411
to
6ddb5a6
Compare
atoulme
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
theletterf
reviewed
Mar 7, 2023
Do you mind adding a readme with a high level description of the bundle and example links to the action artifacts? |
Should the bundles be versioned? If so, should we use the same version as the collector, or something else? |
I vote for the same version as the collector. |
4a6de60
to
3aac295
Compare
rmfitzpatrick
approved these changes
Mar 7, 2023
96ac7cc
to
fb72ca5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splunk-otel-collector
amd64 packages (deb, rpm, tar, docker, msi) to include this bundle instead of the smart agent bundlepkg/signalfx-agent/bundle/Dockerfile
based on https://github.com/signalfx/signalfx-agent/blob/main/Dockerfilepkg/signalfx-agent/bundle/java
files copied from https://github.com/signalfx/signalfx-agent/tree/main/javapkg/signalfx-agent/bundle/python
files copied from https://github.com/signalfx/signalfx-agent/tree/main/pythonagent-bundle_<VERSION>_linux_amd64.tar.gz
andagent-bundle_<VERSION>_windows_amd64.zip
in the github release