[Tanzu Tile] Fix proxy exclusions bug #3902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NO_PROXY environment variable was previously not being set properly by the Tanzu Tile configuration option. This was because the input variable's name was being automatically converted from otel_proxy_no to otel_proxy_false internally, but the variable setting logic was still checking otel_proxy_no. Change name to otel_proxy_exclusions to avoid this.
crobert-1
commented
Nov 9, 2023
| @@ -1,9 +1,10 @@ | |||
| <% if p('otel.proxy.http', '').length > 0 %> | |||
| export HTTP_PROXY=<%= p('otel.proxy.http') %> | |||
| export http_proxy=<%= p('otel.proxy.http') %> | |||
There was a problem hiding this comment.
Some architectures expect this in lower case (http_proxy), so I've added it as a safe-guard here.
| @@ -94,16 +94,16 @@ forms: | |||
| - name: otel_proxy_http | |||
| type: string | |||
| label: HTTP proxy URL | |||
| description: URL used as the proxy URL for HTTP requests unless overridden by otel_proxy_no | |||
| description: URL used as the proxy URL for HTTP requests unless overridden by "Proxy exclusions" | |||
There was a problem hiding this comment.
This is in the Tanzu Tile UI, so the user wouldn't know what otel_proxy_no is referring to. The text box is labelled Proxy exclusions, so this makes the text box's description consistent with the UI's label.
| optional: true | ||
|
|
||
| - name: otel_proxy_no | ||
| - name: otel_proxy_exclusions |
There was a problem hiding this comment.
Variable name underscores are converted to periods when being used in the BOSH job. (That's why the BOSH job references otel.proxy.exclusions, but then the Tanzu Tile references otel_proxy_exclusions)
dloucasfx
approved these changes
Nov 9, 2023
atoulme
approved these changes
Nov 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The NO_PROXY environment variable was previously not being set properly by the Tanzu Tile configuration option. This was because the input variable's name was being automatically converted from otel_proxy_no to otel_proxy_false internally, but the variable setting logic was still checking otel_proxy_no. Change name to otel_proxy_exclusions to avoid this.
Testing:
Manually tested both the BOSH job and Tanzu Tile to ensure changes work properly.
Documentation:
Added some more