Skip to content

Enable Cumulative to Delta Processor #4401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

dmitrykruglov
Copy link
Contributor

Description:

Enabling Cumulative to Delta processor which would allow for converting cumulative monotonic metrics to delta metrics.

Link to Splunk idea: https://ideas.splunk.com/ideas/SFXIMMID-I-599

Testing:

  • Has been tested with a splunk-otel-collector helm chart (w/ a custom-built image) deployed in an EKS cluster, with the "cumulativetodelta" processor enabled in the processors config, and the processor added to the "metrics" pipeline like so:
metrics:
  processors:
  - memory_limiter
  - cumulativetodelta
  - k8sattributes/metrics
  - batch
  - resourcedetection
  - resource

We have confirmed that the metrics values that used to be ever-increasing monotonic numbers have become deltas as a result.

  • Unit tests pass

Documentation: I've updated the list of components doc to include the cumulativetodelta processor (as part of this PR).

This processor would allow for converting cumulative monotonic metrics to delta metrics.
@dmitrykruglov dmitrykruglov requested review from a team as code owners March 6, 2024 21:55
Copy link
Contributor

github-actions bot commented Mar 6, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@dmitrykruglov
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

srv-gh-o11y-gdi-cla added a commit to splunk/cla-agreement that referenced this pull request Mar 6, 2024
Copy link
Contributor

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add an entry in CHANGELOG.md for this, under a new components header. Link for an example.

@dmitrykruglov
Copy link
Contributor Author

Thank you all for the review. I've just updated the changelog as well.

@jvoravong jvoravong merged commit 8588399 into signalfx:main Mar 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants