Skip to content

Replace the SAPM exporter with OTLP HTTP in default configs #5588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Dec 16, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
ead2c04
switch from sapm to otlphttp as default
asreehari-splunk Nov 7, 2024
70a453a
missing update
asreehari-splunk Nov 18, 2024
1df9f57
update trace url for chef tests
asreehari-splunk Nov 18, 2024
22d4438
update trace endpoint for sapm
asreehari-splunk Nov 18, 2024
be25146
Updating zeroconfig\windows tests
pjanotti Nov 20, 2024
16eba48
zeroconfig/windows: network needs to be set as "external"
pjanotti Nov 20, 2024
a5989e0
switch from sapm to otlphttp as default
asreehari-splunk Nov 7, 2024
0367e2a
missing update
asreehari-splunk Nov 18, 2024
6205f06
update trace url for chef tests
asreehari-splunk Nov 18, 2024
0363330
update trace endpoint for sapm
asreehari-splunk Nov 18, 2024
26fc39f
Updating zeroconfig\windows tests
pjanotti Nov 20, 2024
e109170
zeroconfig/windows: network needs to be set as "external"
pjanotti Nov 20, 2024
a3fe7c1
comment out provo mirror
asreehari-splunk Nov 20, 2024
d05fd07
Merge branch 'sapm_to_otlphttp' of github.com:asreehari-splunk/splunk…
pjanotti Nov 22, 2024
f5dd888
get info about docker compose error
pjanotti Nov 22, 2024
db06c59
Add files missing to docker compose build
pjanotti Nov 22, 2024
61c1041
Build the ASP.NET app
pjanotti Nov 23, 2024
0871382
Revert commits to investigate docker compose error
pjanotti Nov 23, 2024
42b6377
Restore parts of docker-compose.yaml
pjanotti Nov 23, 2024
e4286c3
use trace_url for traces endpoint
asreehari-splunk Nov 25, 2024
798407a
Merge branch 'main' into sapm_to_otlphttp
asreehari-splunk Dec 4, 2024
f5fcd0f
Merge branch 'main' into sapm_to_otlphttp
asreehari-splunk Dec 10, 2024
d4aae4d
update test to match endpoint
asreehari-splunk Dec 11, 2024
ec80ea2
metrics endpoint is not required
asreehari-splunk Dec 12, 2024
3cbc174
Update cmd/otelcol/config/collector/ecs_ec2_config.yaml
dmitryax Dec 12, 2024
6e54e6c
update other fips configs
asreehari-splunk Dec 13, 2024
f0f3e3b
Merge branch 'main' into sapm_to_otlphttp
asreehari-splunk Dec 13, 2024
017caa3
update TA configs with otlphttp exporter
asreehari-splunk Dec 13, 2024
cb671b4
Merge branch 'main' into sapm_to_otlphttp
dmitryax Dec 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/scripts/win-test-services.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ $expected_svc_env_vars = @{
"SPLUNK_REALM" = "$realm";
"SPLUNK_API_URL" = "$api_url";
"SPLUNK_INGEST_URL" = "$ingest_url";
"SPLUNK_TRACE_URL" = "${ingest_url}/v2/trace";
# We no longer test for this as we have moved to OTLP and it breaks upgrade tests.
#"SPLUNK_TRACE_URL" = "${ingest_url}/v2/trace/otlp";
"SPLUNK_HEC_URL" = "${ingest_url}/v1/log";
"SPLUNK_HEC_TOKEN" = "$access_token";
"SPLUNK_BUNDLE_DIR" = "${env:PROGRAMFILES}\Splunk\OpenTelemetry Collector\agent-bundle";
Expand Down
19 changes: 12 additions & 7 deletions cmd/otelcol/config/collector/agent_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
# - SPLUNK_HEC_URL: The Splunk HEC endpoint URL, e.g. https://ingest.us0.signalfx.com/v1/log
# - SPLUNK_INGEST_URL: The Splunk ingest URL, e.g. https://ingest.us0.signalfx.com
# - SPLUNK_LISTEN_INTERFACE: The network interface the agent receivers listen on.
# - SPLUNK_TRACE_URL: The Splunk trace endpoint URL, e.g. https://ingest.us0.signalfx.com/v2/trace
# - SPLUNK_TRACE_URL: The Splunk trace endpoint URL, e.g. https://ingest.us0.signalfx.com/v2/trace/otlp

extensions:
health_check:
Expand Down Expand Up @@ -129,7 +129,7 @@ exporters:
# Traces
sapm:
access_token: "${SPLUNK_ACCESS_TOKEN}"
endpoint: "${SPLUNK_TRACE_URL}"
endpoint: "${SPLUNK_INGEST_URL}/v2/trace"
# Metrics + Events
signalfx:
access_token: "${SPLUNK_ACCESS_TOKEN}"
Expand Down Expand Up @@ -157,8 +157,13 @@ exporters:
token: "${SPLUNK_ACCESS_TOKEN}"
endpoint: "${SPLUNK_INGEST_URL}/v1/log"
log_data_enabled: false
otlphttp:
metrics_endpoint: "${SPLUNK_INGEST_URL}/v2/datapoint/otlp"
traces_endpoint: "${SPLUNK_INGEST_URL}/v2/trace/otlp"
headers:
"X-SF-Token": "${SPLUNK_ACCESS_TOKEN}"
# Send to gateway
otlp:
otlp/gateway:
endpoint: "${SPLUNK_GATEWAY_URL}:4317"
tls:
insecure: true
Expand All @@ -179,15 +184,15 @@ service:
- batch
- resourcedetection
#- resource/add_environment
exporters: [sapm, signalfx]
exporters: [otlphttp, signalfx]
# Use instead when sending to gateway
#exporters: [otlp, signalfx]
#exporters: [otlp/gateway, signalfx]
metrics:
receivers: [hostmetrics, otlp, signalfx]
processors: [memory_limiter, batch, resourcedetection]
exporters: [signalfx]
# Use instead when sending to gateway
#exporters: [otlp]
#exporters: [otlp/gateway]
metrics/internal:
receivers: [prometheus/internal]
processors: [memory_limiter, batch, resourcedetection]
Expand All @@ -212,4 +217,4 @@ service:
#- resource/add_environment
exporters: [splunk_hec, splunk_hec/profiling]
# Use instead when sending to gateway
#exporters: [otlp]
#exporters: [otlp/gateway]
7 changes: 6 additions & 1 deletion cmd/otelcol/config/collector/ecs_ec2_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,11 @@ exporters:
token: "${SPLUNK_ACCESS_TOKEN}"
endpoint: "${SPLUNK_INGEST_URL}/v1/log"
log_data_enabled: false
otlphttp:
metrics_endpoint: "${SPLUNK_INGEST_URL}/v2/datapoint/otlp"
traces_endpoint: "${SPLUNK_INGEST_URL}/v2/trace/otlp"
headers:
"X-SF-Token": "${SPLUNK_ACCESS_TOKEN}"

service:
extensions: [health_check, http_forwarder, zpages]
Expand All @@ -140,7 +145,7 @@ service:
- batch
- resourcedetection
#- resource/add_environment
exporters: [sapm, signalfx]
exporters: [otlphttp, signalfx]
metrics:
receivers: [hostmetrics, otlp, signalfx, awsecscontainermetrics]
processors: [memory_limiter, batch, filter, resourcedetection]
Expand Down
7 changes: 6 additions & 1 deletion cmd/otelcol/config/collector/fargate_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,11 @@ exporters:
token: "${SPLUNK_ACCESS_TOKEN}"
endpoint: "${SPLUNK_INGEST_URL}/v1/log"
log_data_enabled: false
otlphttp:
metrics_endpoint: "${SPLUNK_INGEST_URL}/v2/datapoint/otlp"
traces_endpoint: "${SPLUNK_INGEST_URL}/v2/trace/otlp"
headers:
"X-SF-Token": "${SPLUNK_ACCESS_TOKEN}"

service:
extensions: [health_check, http_forwarder, zpages]
Expand All @@ -123,7 +128,7 @@ service:
- batch
- resourcedetection
#- resource/add_environment
exporters: [sapm, signalfx]
exporters: [otlphttp, signalfx]
metrics:
receivers: [otlp, signalfx, awsecscontainermetrics, prometheus/internal]
processors: [memory_limiter, batch, resourcedetection]
Expand Down
2 changes: 1 addition & 1 deletion cmd/otelcol/config/collector/full_config_linux.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -774,7 +774,7 @@ service:
- memory_limiter
- batch
#- resource/add_environment
exporters: [sapm, signalfx]
exporters: [otlphttp, signalfx]
metrics:
receivers: [otlp, signalfx]
processors: [memory_limiter, batch]
Expand Down
9 changes: 7 additions & 2 deletions cmd/otelcol/config/collector/gateway_config.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Configuration file that uses the Splunk exporters (SAPM, SignalFx) to push
# Configuration file that uses the Splunk exporters (OTLPHTTP, SignalFx) to push
# data to Splunk products.

extensions:
Expand Down Expand Up @@ -125,6 +125,11 @@ exporters:
token: "${SPLUNK_ACCESS_TOKEN}"
endpoint: "${SPLUNK_INGEST_URL}/v1/log"
log_data_enabled: false
otlphttp:
metrics_endpoint: "${SPLUNK_INGEST_URL}/v2/datapoint/otlp"
traces_endpoint: "${SPLUNK_INGEST_URL}/v2/trace/otlp"
headers:
"X-SF-Token": "${SPLUNK_ACCESS_TOKEN}"

service:
telemetry:
Expand All @@ -138,7 +143,7 @@ service:
- memory_limiter
- batch
#- resource/add_environment
exporters: [sapm]
exporters: [otlphttp]
metrics:
receivers: [otlp, signalfx]
processors: [memory_limiter, batch]
Expand Down
21 changes: 13 additions & 8 deletions cmd/otelcol/config/collector/upstream_agent_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# - SPLUNK_HEC_TOKEN: The Splunk HEC authentication token
# - SPLUNK_HEC_URL: The Splunk HEC endpoint URL, e.g. https://ingest.us0.signalfx.com/v1/log
# - SPLUNK_INGEST_URL: The Splunk ingest URL, e.g. https://ingest.us0.signalfx.com
# - SPLUNK_TRACE_URL: The Splunk trace endpoint URL, e.g. https://ingest.us0.signalfx.com/v2/trace
# - SPLUNK_TRACE_URL: The Splunk trace endpoint URL, e.g. https://ingest.us0.signalfx.com/v2/trace/otlp

extensions:
health_check:
Expand Down Expand Up @@ -143,8 +143,13 @@ exporters:
token: "${SPLUNK_ACCESS_TOKEN}"
endpoint: "https://ingest.${SPLUNK_REALM}.signalfx.com/v1/log"
log_data_enabled: false
otlphttp:
metrics_endpoint: "${SPLUNK_INGEST_URL}/v2/datapoint/otlp"
traces_endpoint: "${SPLUNK_INGEST_URL}/v2/trace/otlp"
headers:
"X-SF-Token": "${SPLUNK_ACCESS_TOKEN}"
# Send to gateway
otlp:
otlp/gateway:
endpoint: "${SPLUNK_GATEWAY_URL}:4317"
tls:
insecure: true
Expand All @@ -163,30 +168,30 @@ service:
- batch
- resourcedetection
#- resource/add_environment
exporters: [sapm, signalfx]
exporters: [otlphttp, signalfx]
# Use instead when sending to gateway
#exporters: [otlp, signalfx]
#exporters: [otlp/gateway, signalfx]
# Required for Splunk Infrastructure Monitoring
metrics:
receivers: [hostmetrics, otlp, signalfx]
processors: [memory_limiter, batch, resourcedetection]
exporters: [signalfx]
# Use instead when sending to gateway
#exporters: [otlp]
#exporters: [otlp/gateway]
# Required for Splunk APM and/or Infrastructure Monitoring
metrics/internal:
receivers: [prometheus/internal]
processors: [memory_limiter, batch, resourcedetection]
exporters: [signalfx]
# Use instead when sending to gateway
#exporters: [otlp]
#exporters: [otlp/gateway]
# Required for Splunk Infrastructure Monitoring
logs/signalfx:
receivers: [signalfx]
processors: [memory_limiter, batch]
exporters: [signalfx]
# Use instead when sending to gateway
#exporters: [otlp]
#exporters: [otlp/gateway]
logs/entities:
# Receivers are dynamically added if discovery mode is enabled
receivers: [nop]
Expand All @@ -202,4 +207,4 @@ service:
#- resource/add_environment
exporters: [splunk_hec/profiling]
# Use instead when sending to gateway
#exporters: [otlp]
#exporters: [otlp/gateway]
2 changes: 1 addition & 1 deletion cmd/otelcol/fips/config/agent_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ exporters:
# Traces
sapm:
access_token: "${SPLUNK_ACCESS_TOKEN}"
endpoint: "${SPLUNK_TRACE_URL}"
endpoint: "${SPLUNK_INGEST_URL}/v2/trace"
# Metrics + Events
signalfx:
access_token: "${SPLUNK_ACCESS_TOKEN}"
Expand Down
2 changes: 1 addition & 1 deletion deployments/ansible/molecule/custom_vars/verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

- name: Assert SPLUNK_TRACE_URL env var is set
ansible.builtin.lineinfile:
line: SPLUNK_TRACE_URL=https://fake-splunk-ingest.com/v2/trace
line: SPLUNK_TRACE_URL=https://fake-splunk-ingest.com/v2/trace/otlp
dest: /etc/otel/collector/splunk-otel-collector.conf
state: present
check_mode: yes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
SPLUNK_CONFIG: '{{ ansible_env.ProgramData }}\Splunk\OpenTelemetry Collector\custom_config.yml'
SPLUNK_INGEST_URL: https://fake-splunk-ingest.com
SPLUNK_API_URL: https://fake-splunk-api.com
SPLUNK_TRACE_URL: https://fake-splunk-ingest.com/v2/trace
SPLUNK_TRACE_URL: https://fake-splunk-ingest.com/v2/trace/otlp
SPLUNK_HEC_URL: https://fake-splunk-hec.com
SPLUNK_HEC_TOKEN: fake-hec-token
SPLUNK_MEMORY_TOTAL_MIB: "256"
Expand Down
2 changes: 1 addition & 1 deletion deployments/ansible/molecule/default/Dockerfile.j2
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ RUN zypper -n clean && zypper -n refresh
RUN zypper -n install -l ansible dbus-1 rpm-python sudo systemd-sysvinit
{% else %}
FROM opensuse/leap:15
RUN sed -i 's|download.opensuse.org|provo-mirror.opensuse.org|' /etc/zypp/repos.d/*.repo
#RUN sed -i 's|download.opensuse.org|provo-mirror.opensuse.org|' /etc/zypp/repos.d/*.repo
RUN zypper -n install -l ansible dbus-1 python3-rpm sudo systemd-sysvinit
{% endif %}

Expand Down
2 changes: 1 addition & 1 deletion deployments/ansible/molecule/default/verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@

- name: Assert SPLUNK_TRACE_URL env var is set
ansible.builtin.lineinfile:
line: SPLUNK_TRACE_URL=https://ingest.fake-realm.signalfx.com/v2/trace
line: SPLUNK_TRACE_URL=https://ingest.fake-realm.signalfx.com/v2/trace/otlp
dest: /etc/otel/collector/splunk-otel-collector.conf
state: present
check_mode: yes
Expand Down
2 changes: 1 addition & 1 deletion deployments/ansible/molecule/default/windows-verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
SPLUNK_HEC_TOKEN: fake-token
SPLUNK_HEC_URL: https://ingest.fake-realm.signalfx.com/v1/log
SPLUNK_INGEST_URL: https://ingest.fake-realm.signalfx.com
SPLUNK_TRACE_URL: https://ingest.fake-realm.signalfx.com/v2/trace
SPLUNK_TRACE_URL: https://ingest.fake-realm.signalfx.com/v2/trace/otlp
tasks:
- name: Check splunk-otel-collector service
ansible.windows.win_service:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
SPLUNK_HEC_TOKEN: fake-token
SPLUNK_HEC_URL: https://ingest.fake-realm.signalfx.com/v1/log
SPLUNK_INGEST_URL: https://ingest.fake-realm.signalfx.com
SPLUNK_TRACE_URL: https://ingest.fake-realm.signalfx.com/v2/trace
SPLUNK_TRACE_URL: https://ingest.fake-realm.signalfx.com/v2/trace/otlp
iis_reg_values:
COR_ENABLE_PROFILING: "1"
COR_PROFILER: "{B4C89B0F-9908-4F73-9F59-0D77C5A06874}"
Expand Down
4 changes: 2 additions & 2 deletions deployments/ansible/roles/collector/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ $> ansible-playbook playbook.yaml -e start_service=false
collector service. (**default:** `https://api.{{ splunk_realm }}.signalfx.com`)

- `splunk_trace_url`: The Splunk trace endpoint URL, e.g.
`https://ingest.us0.signalfx.com/v2/trace`. The `SPLUNK_TRACE_URL` environment
`https://ingest.us0.signalfx.com/v2/trace/otlp`. The `SPLUNK_TRACE_URL` environment
variable will be set with this value for the collector service. (**default:**
`{{ splunk_ingest_url }}/v2/trace`)
`{{ splunk_ingest_url }}/v2/trace/otlp`)

- `splunk_hec_url`: The Splunk HEC endpoint URL, e.g.
`https://ingest.us0.signalfx.com/v1/log`. The `SPLUNK_HEC_URL` environment
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

- name: Set default trace url
set_fact:
splunk_trace_url: "{{splunk_ingest_url}}/v2/trace"
splunk_trace_url: "{{splunk_ingest_url}}/v2/trace/otlp"
when: splunk_trace_url is not defined or (splunk_trace_url | trim) == ""

- name: Set default hec url
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ SPLUNK_INGEST_URL={{ splunk_ingest_url | default("https://ingest." + splunk_real
{% if splunk_trace_url is defined and splunk_trace_url %}
SPLUNK_TRACE_URL={{ splunk_trace_url }}
{% elif splunk_ingest_url is defined and splunk_ingest_url %}
SPLUNK_TRACE_URL={{ splunk_ingest_url + "/v2/trace" }}
SPLUNK_TRACE_URL={{ splunk_ingest_url + "/v2/trace/otlp" }}
{% else %}
SPLUNK_TRACE_URL={{ "https://ingest." + splunk_realm + ".signalfx.com/v2/trace" }}
{% endif %}
Expand Down
2 changes: 1 addition & 1 deletion deployments/chef/attributes/default.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

default['splunk_otel_collector']['splunk_api_url'] = "https://api.#{node['splunk_otel_collector']['splunk_realm']}.signalfx.com"
default['splunk_otel_collector']['splunk_ingest_url'] = "https://ingest.#{node['splunk_otel_collector']['splunk_realm']}.signalfx.com"
default['splunk_otel_collector']['splunk_trace_url'] = "#{node['splunk_otel_collector']['splunk_ingest_url']}/v2/trace"
default['splunk_otel_collector']['splunk_trace_url'] = "#{node['splunk_otel_collector']['splunk_ingest_url']}/v2/trace/otlp"
default['splunk_otel_collector']['splunk_hec_url'] = "#{node['splunk_otel_collector']['splunk_ingest_url']}/v1/log"
default['splunk_otel_collector']['splunk_hec_token'] = "#{node['splunk_otel_collector']['splunk_access_token']}"
default['splunk_otel_collector']['splunk_memory_total_mib'] = '512'
Expand Down
2 changes: 1 addition & 1 deletion deployments/chef/test/integration/custom_vars/test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
splunk_realm = 'test'
splunk_api_url = 'https://fake-splunk-api.com'
splunk_ingest_url = 'https://fake-splunk-ingest.com'
splunk_trace_url = "#{splunk_ingest_url}/v2/trace"
splunk_trace_url = "#{splunk_ingest_url}/v2/trace/otlp"
splunk_hec_url = "#{splunk_ingest_url}/v1/log"
splunk_hec_token = 'fake-hec-token'
splunk_memory_total = '256'
Expand Down
2 changes: 1 addition & 1 deletion deployments/chef/test/integration/default/test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
splunk_realm = 'test'
splunk_api_url = "https://api.#{splunk_realm}.signalfx.com"
splunk_ingest_url = "https://ingest.#{splunk_realm}.signalfx.com"
splunk_trace_url = "#{splunk_ingest_url}/v2/trace"
splunk_trace_url = "#{splunk_ingest_url}/v2/trace/otlp"
splunk_hec_url = "#{splunk_ingest_url}/v1/log"
splunk_hec_token = splunk_access_token
splunk_memory_total = '512'
Expand Down
5 changes: 5 additions & 0 deletions deployments/nomad/otel-agent.nomad
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,11 @@ exporters:
sync_host_metadata: true
debug:
verbosity: detailed
otlphttp:
metrics_endpoint: "https://ingest.${SPLUNK_REALM}.signalfx.com/v2/datapoint/otlp"
traces_endpoint: "https://ingest.${SPLUNK_REALM}.signalfx.com/v2/trace/otlp"
headers:
"X-SF-Token": "${SPLUNK_ACCESS_TOKEN}"
service:
extensions:
- health_check
Expand Down
5 changes: 5 additions & 0 deletions deployments/nomad/otel-gateway.nomad
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,11 @@ exporters:
ingest_url: https://ingest.${SPLUNK_REALM}.signalfx.com
debug:
verbosity: detailed
otlphttp:
metrics_endpoint: "https://ingest.${SPLUNK_REALM}.signalfx.com/v2/datapoint/otlp"
traces_endpoint: "https://ingest.${SPLUNK_REALM}.signalfx.com/v2/trace/otlp"
headers:
"X-SF-Token": "${SPLUNK_ACCESS_TOKEN}"
service:
extensions:
- health_check
Expand Down
2 changes: 1 addition & 1 deletion deployments/puppet/manifests/init.pp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
$splunk_realm = '', # required
$splunk_ingest_url = "https://ingest.${splunk_realm}.signalfx.com",
$splunk_api_url = "https://api.${splunk_realm}.signalfx.com",
$splunk_trace_url = "${splunk_ingest_url}/v2/trace",
$splunk_trace_url = "${splunk_ingest_url}/v2/trace/otlp",
$splunk_hec_url = "${splunk_ingest_url}/v1/log",
$splunk_hec_token = $splunk_access_token,
$splunk_bundle_dir = $splunk_otel_collector::params::splunk_bundle_dir,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

{% set splunk_ingest_url = salt['pillar.get']('splunk-otel-collector:splunk_ingest_url', 'https://ingest.' + splunk_realm + '.signalfx.com') %}

{% set splunk_trace_url = salt['pillar.get']('splunk-otel-collector:splunk_trace_url', splunk_ingest_url + '/v2/trace') %}
{% set splunk_trace_url = salt['pillar.get']('splunk-otel-collector:splunk_trace_url', splunk_ingest_url + '/v2/trace/otlp') %}

{% set splunk_hec_url = salt['pillar.get']('splunk-otel-collector:splunk_hec_url', splunk_ingest_url + '/v1/log') %}

Expand Down
2 changes: 1 addition & 1 deletion internal/settings/settings.go
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ func setDefaultEnvVars(s *Settings) error {
envVars = append(envVars,
ev{e: APIURLEnvVar, v: fmt.Sprintf("https://api.%s.signalfx.com", realm)},
ev{e: IngestURLEnvVar, v: fmt.Sprintf("https://ingest.%s.signalfx.com", realm)},
ev{e: TraceIngestURLEnvVar, v: fmt.Sprintf("https://ingest.%s.signalfx.com/v2/trace", realm)},
ev{e: TraceIngestURLEnvVar, v: fmt.Sprintf("https://ingest.%s.signalfx.com/v2/trace/otlp", realm)},
ev{e: HecLogIngestURLEnvVar, v: fmt.Sprintf("https://ingest.%s.signalfx.com/v1/log", realm)},
)
}
Expand Down
Loading
Loading