Add entites for Agent - GW setup #6311
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6311 +/- ##
==========================================
+ Coverage 36.83% 44.81% +7.97%
==========================================
Files 381 390 +9
Lines 26732 26995 +263
==========================================
+ Hits 9848 12099 +2251
+ Misses 15908 14023 -1885
+ Partials 976 873 -103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dloucasfx
force-pushed
the
entitiesGW
branch
2 times, most recently
from
c3e6f71 to
27e55e5
Compare
Signed-off-by: Dani Louca <[email protected]>
| # Use instead when sending to gateway | ||
| # endpoint: http://${SPLUNK_GATEWAY_URL}:4318 |
There was a problem hiding this comment.
| # Use instead when sending to gateway | |
| # endpoint: http://${SPLUNK_GATEWAY_URL}:4318 | |
| # Use instead when sending to gateway | |
| # endpoint: ${SPLUNK_GATEWAY_URL}:4318 |
Is http:// required here? Same question for other usages. I'm wondering why the value provided isn't consistent with usage of other environment variables.
| @@ -142,6 +142,22 @@ exporters: | |||
| token: "${SPLUNK_ACCESS_TOKEN}" | |||
| endpoint: "${SPLUNK_INGEST_URL}/v1/log" | |||
| log_data_enabled: false | |||
| # To send entities (applicable only if discovery mode is enabled) | |||
| otlphttp/entities: | |||
There was a problem hiding this comment.
If this is only relevant when discovery is enabled, is there some way to tie this to discovery mode? (The pipeline is only enabled when discovery mode is enabled?)
| default_pipelines: [logs] | ||
| table: | ||
| - context: log | ||
| condition: instrumentation_scope.attributes["otel.entity.event_as_log"] == true |
There was a problem hiding this comment.
Where does otel.entity.event_as_log come from? Is there some way we could use a central variable or constant here? Not required as it might be a bit messy, just concerned about the possibility of this changing in the future.
|
I haven't seen that Please check to make sure it's not caused by this PR, we can address later if it's unrelated. |
Description:
Link to Splunk idea: <Link to Splunk idea, see https://ideas.splunk.com>
Testing:
Documentation: