Skip to content

[DRAFT][chore] Fix nolint due to testcontainers deprecations #6334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pjanotti
Copy link
Contributor

Use the new recommended way and avoid using the deprecated type.

Copy link

codecov bot commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 27.01%. Comparing base (c006b31) to head (2f39e96).

Files with missing lines Patch % Lines
tests/testutils/container.go 66.66% 2 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (27.01%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (c006b31) and HEAD (2f39e96). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (c006b31) HEAD (2f39e96)
33 28
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6334       +/-   ##
===========================================
- Coverage   44.86%   27.01%   -17.85%     
===========================================
  Files         390      381        -9     
  Lines       26995    26710      -285     
===========================================
- Hits        12111     7216     -4895     
- Misses      14014    18736     +4722     
+ Partials      870      758      -112     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant