Skip to content

DEMRUM-773: Network Monitor Module #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: feature/next-gen
Choose a base branch
from
Open

DEMRUM-773: Network Monitor Module #304

wants to merge 23 commits into from
+421 −3

Conversation

SMickelsn
Copy link
Contributor

@SMickelsn SMickelsn commented May 20, 2025 •
edited by aditi-s3
Loading

Screenshot 2025-06-17 at 5 47 34 PM
Screenshot 2025-06-17 at 5 51 23 PM

  • Module to detect Network Info - connection type [tested e2e with simulator see screenshot]
  • Added option to include network.connection.subtype for radio technologies
  • Sends network.change spans only when state changes [Not tested as do not have a real device]
  • Added module configuration to enable/disable
  • Resolved lint issues
  • Unit tests not included - separate ticket

@SMickelsn SMickelsn requested review from a team as code owners May 20, 2025 19:28
@SMickelsn SMickelsn marked this pull request as draft May 20, 2025 19:28
@SMickelsn SMickelsn marked this pull request as ready for review June 3, 2025 01:39
@SMickelsn SMickelsn changed the title DEMRUM-773 Initial Network Info method DEMRUM-773 Network Info Module Jun 3, 2025
carlosmcevilly
carlosmcevilly approved these changes Jun 3, 2025
View reviewed changes
Copy link

@carlosmcevilly carlosmcevilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There was one nit but we can catch that one next time if you want to merge this as is.

@aditi-s3 aditi-s3 requested a review from jCharv June 3, 2025 19:13
@SMickelsn SMickelsn changed the title DEMRUM-773 Network Info Module DEMRUM-773: Network Info Module Jun 17, 2025
@aditi-s3 aditi-s3 marked this pull request as draft June 17, 2025 23:52
@aditi-s3 aditi-s3 changed the title DEMRUM-773: Network Info Module DEMRUM-773: Network Monitor Module Jun 18, 2025
@aditi-s3 aditi-s3 marked this pull request as ready for review June 18, 2025 01:09
@aditi-s3 aditi-s3 requested a review from carlosmcevilly June 18, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jCharv jCharv Awaiting requested review from jCharv

@carlosmcevilly carlosmcevilly Awaiting requested review from carlosmcevilly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SMickelsn @carlosmcevilly @aditi-s3