DEMRUM-861: cleanups in custom tracking #341
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypes - Remove typeName from SplunkTrackable protocol. - Use typeName in SplunkTrackableIssue to capture OTel attribute "exception.name" value e.g. NSError. - Rename typeName in SplunkTrackableEvent to capture event name as passed into API call. - Use hard coded "error" as name field in any error type. - Make typeName reflect the actual type we get, such as a subclass of an error type.
…mp so we always set it on init
…f available. - exceptionCode mapping to OTel exception.code. - codeNamespace mapping to OTel code.namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typeNameto have a better nameeventNamefor custom event tracking.timestampin Custom Tracking events and errors.track(error:)calls to remove a redundancy.NSError.codeand.domain. This can be further improved in the future to also parse the message field but that's not in this code for now.NSErrorsubclass, whose class name will be reported in attributeexception.type.This PR is hoped to be the last (or close to the last) changes to the feature branch before we make a PR for merging the
feature/customTrackingbranch intofeature/next-gen. Unit tests are not included yet and will be done separately. The demo app does exercise the features.If trying this out in Xcode, you'll see stacktrace data in the console; this is intended and is part of the span for errors -- currently not compressed+encoded, but that could be a future step to take.