[UX] Add git commit hash to queue #5999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucamanolache
force-pushed
the
luca/git-info
branch
from
5eed8d3 to
b92c0a8
Compare
|
/quicktest-core |
|
/quicktest-core |
|
/quicktest-core |
|
/quicktest-core |
|
/quicktest-core |
|
/quicktest-core |
|
/quicktest-core |
|
/quicktest-core |
|
/quicktest-core |
|
/smoke-test |
cg505
reviewed
Jun 16, 2025
There was a problem hiding this comment.
Thanks for the PR @lucamanolache!
Nit about PR title - the convention for PRs and commit messages is to use imperative tense rather than declarative. E.g. "Add commit hash to queue.
sky/skylet/constants.py
Outdated
| SKYLET_LIB_VERSION = 3 | ||
| SKYLET_LIB_VERSION = 4 |
There was a problem hiding this comment.
I think if we're updating the SKYLET_VERSION, we don't need to also update this.
|
/smoke-test |
|
/smoke-test |
lucamanolache
changed the title
|
/smoke-test |
|
/smoke-test |
|
/quicktest-core |
|
/smoke-test |
cg505
reviewed
Jul 8, 2025
|
/smoke-test |
|
/smoke-test -k test_private_docker_registry |
|
/smoke-test |
|
/smoke-test |
cg505
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the commit hash of the workdir (if it is a git repo) when doing
sky queueorsky jobs queue.Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)