Forward priority to k8s #6012
Closed
Forward priority to k8s #6012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeungjinYang
force-pushed
the
k8s-priority
branch
3 times, most recently
from
650a619 to
ce0b266
Compare
|
/quicktest-core |
SeungjinYang
force-pushed
the
k8s-priority
branch
from
1394300 to
360b124
Compare
cg505
approved these changes
Jun 18, 2025
Comment on lines
+509
to
+510
| logger.info('_configure_priority_class: ' | ||
| f'{updating_existing_msg(priority_class_field, name)}') |
Comment on lines
+191
to
+193
| - apiGroups: [ "scheduling.k8s.io" ] | ||
| resources: [ "priorityclasses" ] | ||
| verbs: [ "list", "create", "patch" ] |
There was a problem hiding this comment.
will this get updated correctly? Do we need to update any permissions docs or whatever? (Helm chart??)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)