-
Notifications
You must be signed in to change notification settings - Fork 714
[API server] graceful upgrade with client retry #6048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aylei! The PR looks awesome! Left some questions below. Also, is it possible to have a README for how to test this?
Co-authored-by: Zhanghao Wu <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this possible @aylei! LGTM once the tests passed.
We need the following two things to be added as well:
- Docs for the behavior of the client side retry
- Test script to avoid regression
Signed-off-by: Aylei <[email protected]>
Signed-off-by: Aylei <[email protected]>
/smoke-test https://buildkite.com/skypilot-1/smoke-tests/builds/1590 succeed |
Signed-off-by: Aylei <[email protected]>
/quicktest-core |
Signed-off-by: Aylei <[email protected]>
This PR introduce graceful upgrade support with a client-side retry mechanism, which break down the upgrade process to the following states:
SIGTERM
to API server, API server enters Cordon state. Behavior:/api/get
on the logs requestThe key differences with our previous graceful rolling-upgrade:
Known issues:
UX:
Message when log tailing is interrupted by server upgrade:
Recovered after the upgrade complete:
Tested (run the relevant ones):
bash format.sh
/smoke-test
(CI) orpytest tests/test_smoke.py
(local)/smoke-test -k test_name
(CI) orpytest tests/test_smoke.py::test_name
(local)/quicktest-core
(CI) orpytest tests/smoke_tests/test_backward_compat.py
(local)