Skip to content

Bump slab to v0.4.7 #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Bump slab to v0.4.7 #132

merged 1 commit into from
Dec 3, 2024

Conversation

notgull
Copy link
Member

@notgull notgull commented Oct 6, 2024

Closes #131

Closes #131

Signed-off-by: John Nunley <[email protected]>
@notgull notgull merged commit 76bea84 into master Dec 3, 2024
8 checks passed
@notgull notgull deleted the notgull/new-slab branch December 3, 2024 03:22
@mrzv
Copy link

mrzv commented Apr 27, 2025

Can you please release a new version that includes this change?

@taiki-e
Copy link
Collaborator

taiki-e commented Apr 27, 2025

Creating a new release is fine, but this is just a minimal version issue that can be fixed by just running cargo update without a new release.

@mrzv
Copy link

mrzv commented Apr 27, 2025

Sorry, I don't understand. What do I tell cargo update so it grabs a version of async-executor that includes this change?

@taiki-e
Copy link
Collaborator

taiki-e commented Apr 27, 2025

This PR just raises the minimal version requirement for slab, not the version actually used. Even without an async-executor containing this change, a cargo update on your part will increase the slab version and thus fix the problem.

@mrzv
Copy link

mrzv commented Apr 27, 2025

But it didn't. I ran into this problem precisely after running cargo update (from a 4-year-old code base).

@mrzv
Copy link

mrzv commented Apr 27, 2025

Sorry. I'm wrong, it popped up after cargo upgrade.

@taiki-e
Copy link
Collaborator

taiki-e commented Apr 28, 2025

Since cargo upgrade brings direct dependencies up to the latest version and does nothing for indirect dependencies, so I think that running cargo update should bring the slab version up to date as well.

@mrzv
Copy link

mrzv commented Apr 28, 2025

Yeah, it's all fixed. I got confused between the two commands. Thanks for explaining, and sorry for the spam.

@taiki-e taiki-e mentioned this pull request Apr 28, 2025
@taiki-e
Copy link
Collaborator

taiki-e commented Apr 28, 2025

Published in 1.13.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Old slab version in dependencies breaks build
3 participants