Skip to content

Improve email generation logic #1032

@RichDom2185

Description

@RichDom2185

As mentioned in #1031, I really think #932 is the wrong approach to generate the emails:

image

all_submissions_by_grader_for_index generates a view (JSON string), which is then converted back to a "model" using Jason.decode, which is then further manipulated, and the final view is generated using the email template.

This results in a lot of coupling, especially across the various layers of the backend, which means PRs like #1031 are unnecessarily breaking.

My proposal would be to create a separate function entirely for this functionality, which would optimise everything as well.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions