Skip to content

Upgrades to Achievements UI and removal of Achievement categories #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 4, 2021

Conversation

jonas-chow
Copy link
Contributor

Description

The achievement dashboard for staff has been revamped.

  • Selecting a user in the "top bar" now also causes the achievement progress shown to be that of the selected user.
  • Updating the goal progress of the user now immediately updates the UI
  • Selecting user or goal can now be filtered
  • Staff are now able to toggle the ability to see hidden achievements
  • Achievement Views now have their background images dimmed so the white text is easily visible regardless of background
  • Assessment achievements now have the assessment cover image as the background image
  • Assessment achievements no longer render for staff (less clutter, but you don't get to see exactly what a student sees)

The achievement settings under achievement control also received a few minor changes.

  • Prerequisites and goals can now be filtered
  • It's now clearer whether an achievement has variable XP or not

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Staff Achievement Dashboard

Log in as a staff, and go to the achievement dashboard.
Select a user, select a goal, update a goal progress for the user.
You should see that the goal progress bar increases.
Select another user, and you should see the goal progress bar changing.
Select the same user, and you should see the goal progress bar go back to what you gave the user.

Student Achievement Dashboard

Log in as a staff, and set some assessments to have been released.
Log in as a student, and go to the achievement dashboard.
You should see achievements for the released assessments, with background image that is the cover image of the assessment.

Achievement Control

Ensure that achievement settings still work properly (achievement's goals, prerequisites, variableXP)

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

coveralls commented Jul 30, 2021

Pull Request Test Coverage Report for Build 1081859394

  • 4 of 54 (7.41%) changed or added relevant lines in 7 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.07%) to 29.869%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/sagas/RequestsSaga.ts 0 1 0.0%
src/commons/achievement/utils/AchievementInferencer.ts 0 3 0.0%
src/commons/sagas/AchievementSaga.ts 0 3 0.0%
src/pages/achievement/subcomponents/AchievementDashboard.tsx 0 8 0.0%
src/commons/achievement/control/achievementEditor/achievementSettings/EditablePrerequisiteUuids.tsx 0 10 0.0%
src/commons/achievement/control/achievementEditor/achievementSettings/EditableGoalUuids.tsx 0 12 0.0%
src/commons/achievement/AchievementManualEditor.tsx 4 17 23.53%
Files with Coverage Reduction New Missed Lines %
src/commons/achievement/control/achievementEditor/achievementSettings/EditablePrerequisiteUuids.tsx 1 0%
src/pages/achievement/subcomponents/AchievementDashboard.tsx 1 2.33%
src/commons/achievement/control/achievementEditor/achievementSettings/EditableGoalUuids.tsx 2 0%
Totals Coverage Status
Change from base Build 1080991698: -0.07%
Covered Lines: 3183
Relevant Lines: 9824

💛 - Coveralls

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 30, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: dca9cb0
Status: ✅  Deploy successful!
Preview URL: https://030ae3d7.cadet-frontend.pages.dev

View logs

@jonas-chow jonas-chow changed the base branch from master to multitenant/dev July 30, 2021 10:26
@chownces chownces marked this pull request as draft July 30, 2021 10:50
@chownces
Copy link
Contributor

Hi, could you branch off the current main Rook PR #1878? Also please DO NOT merge this till #1878 is merged.

@chownces chownces force-pushed the sa2122-achievements branch from 600ba75 to b63ff09 Compare August 3, 2021 13:02
@chownces chownces marked this pull request as ready for review August 3, 2021 13:03
@chownces
Copy link
Contributor

chownces commented Aug 3, 2021

rebased

@chownces chownces self-requested a review August 3, 2021 13:04
@angelsl
Copy link
Contributor

angelsl commented Aug 3, 2021

@chownces The commit you created is in the future.. LOL

@chownces
Copy link
Contributor

chownces commented Aug 4, 2021

@chownces The commit you created is in the future.. LOL

Ohh... I just switched distros on my desktop last week, havent got to fixing the windows linux dual boot time issue haha ==

@chownces chownces force-pushed the sa2122-achievements branch from 3f08ab8 to dca9cb0 Compare August 4, 2021 06:33
@chownces chownces changed the title Upgrades to achievement UI Upgrades to Achievements UI and removal of Achievement categories Aug 4, 2021
Copy link
Contributor

@chownces chownces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the much needed changes! Will revisit the achievement categorization in the future.

@angelsl angelsl merged commit cd132ba into multitenant/dev Aug 4, 2021
@angelsl angelsl deleted the sa2122-achievements branch August 4, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants