Fix error & injection of iframe on hot reload #2214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2213.
Same issue as facebook/create-react-app#11773.
There are two solutions outlined in the CRA issue above:
react-scripts
to v5.x.react-error-overlay
via selective dependency resolution.Unfortunately, we cannot upgrade
react-scripts
(CRA) to v5.0x because another dependency that we use, Create React App Configuration Override (CRACO) does not have a stable version that supports CRA v5.x yet:Attempting to do so results in errors when starting the frontend. As such, we have no choice but to go with the second option for now.
Type of change
How to test