Migrate out of Enzyme testing library to facilitate react 18 upgrade #2524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chownces
force-pushed
the
react-testing-lib-migration
branch
from
7ddcc91 to
9db5769
Compare
Pull Request Test Coverage Report for Build 5333112029
💛 - Coveralls |
RichDom2185
approved these changes
Jun 21, 2023
RichDom2185
pushed a commit
to NUS-CS1101S/cadet-frontend
that referenced
this pull request
Jul 15, 2023
…ource-academy#2524) * Add testing-library/react packages * Downgrade react-test-renderer to match current react version * Deprecate enzyme usage * Downgrade @test-library/react to match react version * Continue deprecation of enzyme usage * Migrate Assessment.tsx tests * Migrate dialogs and dropdown tests * Migrate navigation bar tests * Migrate NotificationBadge tests * Migrate profile card tests * Migrate Repl, RessearchAgreementPrompt and SideContentAutograder tests * Migrate remaining side content component tests * Migrate Sicp component tests * Migrate AssessmentWorkspace component tests * Update remaining snapshots after changes * Shift extend-expect import to setup file * Remove enzyme related packages * Fix PR comments
RichDom2185
pushed a commit
to NUS-CS1101S/cadet-frontend
that referenced
this pull request
Aug 15, 2023
…ource-academy#2524) * Add testing-library/react packages * Downgrade react-test-renderer to match current react version * Deprecate enzyme usage * Downgrade @test-library/react to match react version * Continue deprecation of enzyme usage * Migrate Assessment.tsx tests * Migrate dialogs and dropdown tests * Migrate navigation bar tests * Migrate NotificationBadge tests * Migrate profile card tests * Migrate Repl, RessearchAgreementPrompt and SideContentAutograder tests * Migrate remaining side content component tests * Migrate Sicp component tests * Migrate AssessmentWorkspace component tests * Update remaining snapshots after changes * Shift extend-expect import to setup file * Remove enzyme related packages * Fix PR comments
Pull Request Test Coverage Report for Build 5332350829Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #2520
Moving forward, we should probably document down the best practices while onboarding new developers, and point them to the relevant documentation to get started (e.g. React 18, @ testing-library/react, etc.) --> added in #2527
Type of change
How to test
Check through the snapshots. I've tried adding some assertions to the snapshot tests too to improve the robustness of the test suite.
Checklist