Skip to content

Fix grading submissions filter text not showing filter value #2636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

zhyuhan
Copy link
Contributor

@zhyuhan zhyuhan commented Aug 19, 2023

Description

After applying a global filter for submission and then navigating to a sub-route of /grading (e.g. grading a submission), navigating back to /grading retains filter value in the filter state but the input text field stays empty. This fix populates the text input correctly upon returning to the submission table.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

To reproduce the bug:

  1. Apply a global submission filter using the text input
  2. Grade any submission
  3. Go back to /grading using the navbar
  4. The submission are still filtered by the previous global filter (and any additional column filters) but the text input is empty

After the fix the text input in step 4 should show the previously applied filter.

Checklist

  • I have tested this code

@zhyuhan zhyuhan added the Bug Something isn't working label Aug 19, 2023
@zhyuhan zhyuhan requested a review from RichDom2185 August 19, 2023 17:40
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5912726091

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 37.424%

Files with Coverage Reduction New Missed Lines %
src/pages/academy/grading/subcomponents/GradingSubmissionsTable.tsx 1 0%
Totals Coverage Status
Change from base Build 5891888815: -0.004%
Covered Lines: 5739
Relevant Lines: 14413

💛 - Coveralls

@shenyih0ng shenyih0ng merged commit d7ecd5b into master Aug 21, 2023
@shenyih0ng shenyih0ng deleted the fix/grading-filter-input-text branch August 21, 2023 02:56
RichDom2185 pushed a commit to NUS-CS1101S/cadet-frontend that referenced this pull request Aug 25, 2023
RichDom2185 pushed a commit to NUS-CS1101S/cadet-frontend that referenced this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants