Skip to content

2748 remove hints type inference #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 3, 2024

Conversation

ZweZeya
Copy link
Contributor

@ZweZeya ZweZeya commented Feb 2, 2024

Description

Hints provided by type inferences will become redundant with the development of Source Typed.

Type of change

  • Removed UseTypeInference hook from src/commons/editor
  • Removed typeCheck from src/sagas/WorkspaceSage.tsx

How to test

Type hints will no longer be provided when type-incompatible operations are executed. The keyboard shortcut Ctrl-Shift-m will no longer show type information.

Checklist

  • I have tested this code

Closes #2748.

@ZweZeya ZweZeya linked an issue Feb 2, 2024 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Feb 2, 2024

Pull Request Test Coverage Report for Build 7766835537

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 37.226%

Totals Coverage Status
Change from base Build 7766810194: 0.02%
Covered Lines: 5722
Relevant Lines: 14440

💛 - Coveralls

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 enabled auto-merge (squash) February 3, 2024 12:28
@RichDom2185 RichDom2185 merged commit 7b45a82 into master Feb 3, 2024
@RichDom2185 RichDom2185 deleted the 2748-remove-hints-type-inference branch February 3, 2024 12:44
CYX22222003 pushed a commit to CYX22222003/frontendCYX that referenced this pull request Feb 9, 2024
* remove type hints

* remove type inferences cleanup

* remove key binding for type information

---------

Co-authored-by: Richard Dominick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Hints (Type Inference)
3 participants