Refactor frontend part 6 #2800
Merged
Refactor frontend part 6 #2800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves type safety.
This was missed during the initial migration.
Dependents include the associated types and tests.
Improves correctness and consistency.
It was causing the tests to fail.
…nto fe-refactor-6
This is now no longer needed since we made the prop optional.
…nto fe-refactor-6
* Standardize to lambda function * Standardize to `React.FC` typing * Remove unnecessary props parameter typing * Destructure props directly in function parameter
sayomaki
requested changes
Mar 7, 2024
src/pages/academy/gameSimulator/subcomponents/GameSimulatorCheckpointTxtLoader.tsx
Outdated
Show resolved
Hide resolved
src/pages/academy/adminPanel/subcomponents/assessmentConfigPanel/AssessmentConfigPanel.tsx
Outdated
Show resolved
Hide resolved
…nto fe-refactor-6
…nto fe-refactor-6
…nto fe-refactor-6
* Use `React.FC` type for components * Type props as `Props` unless exported * Place props type immediately above component * Use lambda functions for components * Destructure props in function parameter * Use types for props, not interfaces * Combine unnecessary `OwnProps` to props type * Remove unused exports of props types Remaining components will be migrated in the future.
* Type props as `Props` unless exported * Place props type immediately above component
Also removed some unnecessary `useState` type arguments.
Also removed some unnecessary `useState` type arguments.
Prefer the more succint `React.FC` instead.
We want to always use `useTypedSelector` for type-safety.
RichDom2185
commented
Mar 17, 2024
CYX22222003
pushed a commit
that referenced
this pull request
Mar 22, 2024
* Add generic type argument to column definitions Improves type safety. * Migrate bp4 classes to bp5 This was missed during the initial migration. * Remove unused `AcademyReducer` and dependents Dependents include the associated types and tests. * Update imports Improves correctness and consistency. * Fix lint * Undo test import change It was causing the tests to fail. * Remove unnecessay `loadContentDispatch` sometimes This is now no longer needed since we made the prop optional. * Update test snapshots * Make component typings more consistent * Standardize to lambda function * Standardize to `React.FC` typing * Remove unnecessary props parameter typing * Destructure props directly in function parameter * Bump dependencies * Fix class name typo * Change relative import to project-based import * Bump dependencies * Update test snapshots * Standardize typings * Use `React.FC` type for components * Type props as `Props` unless exported * Place props type immediately above component * Use lambda functions for components * Destructure props in function parameter * Use types for props, not interfaces * Combine unnecessary `OwnProps` to props type * Remove unused exports of props types Remaining components will be migrated in the future. * Remove unnecessary generic type arguments * Standardize ControlBar components typings * Type props as `Props` unless exported * Place props type immediately above component * Standardize more component typings Also removed some unnecessary `useState` type arguments. * Fix compile error * Standardize remaining component typings Also removed some unnecessary `useState` type arguments. * Ban `React.FunctionComponent` type Prefer the more succint `React.FC` instead. * Ban `useSelector` import We want to always use `useTypedSelector` for type-safety.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Focuses on fixing bugs (regressions), improving type safety, and removing dead code.
Please refer to commit history for list of changes.
Fixes #2797, though ideally we should not be hardcoding them (i.e., it's not a true "fix" of the root cause).
Also bans the following via ESLint rules (thus technically a breaking change – though the codebase has been updated to ensure everything is compliant):
React.FunctionComponent→ useReact.FCfor succinctnessuseSelector→ useuseTypedSelectorfor type-safetyType of change
How to test
Checklist