Skip to content

Fix reversed condition for filtering by group #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

sayomaki
Copy link
Contributor

@sayomaki sayomaki commented Aug 15, 2024

Description

Right now in the Grading tab of the Academy, the default filter (of all groups) only shows submissions from the user's own groups (filter condition reversed), and this PR fixes it.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

Checklist

  • I have tested this code
  • I have updated the documentation

@sayomaki sayomaki requested a review from RichDom2185 August 15, 2024 14:41
@sayomaki sayomaki self-assigned this Aug 15, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10405611541

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 31.716%

Totals Coverage Status
Change from base Build 10405278900: 0.0%
Covered Lines: 4822
Relevant Lines: 14372

💛 - Coveralls

@RichDom2185
Copy link
Member

Regression from #2787

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 merged commit 739895d into source-academy:master Aug 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants