Skip to content

CSE: Fix minor issues with changepoint steps and envChanging #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2024
Merged

CSE: Fix minor issues with changepoint steps and envChanging #1655

merged 1 commit into from
Apr 9, 2024

Conversation

CZX123
Copy link
Contributor

@CZX123 CZX123 commented Apr 9, 2024

Follow up to previous PR: #1645

Changes

  • Update envChanging to also include environment and array literal instructions
  • Do a copy of the context runtime's breakpoint steps and changepoint steps before running the new CSE Machine to prevent mutations to the original steps arrays
  • Added test cases for breakpoint steps and changepoint steps

@CZX123 CZX123 self-assigned this Apr 9, 2024
@CZX123 CZX123 requested a review from martin-henz April 9, 2024 01:26
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8608900676

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 81.975%
Totals Coverage Status
Change from base Build 8608235409: 0.04%
Covered Lines: 10690
Relevant Lines: 12693
💛 - Coveralls

martin-henz
martin-henz approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@martin-henz martin-henz merged commit 8fc02a7 into master Apr 9, 2024
@martin-henz martin-henz deleted the cse-heap-updates-2 branch April 9, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-henz martin-henz martin-henz approved these changes

Assignees

@CZX123 CZX123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CZX123 @coveralls @martin-henz